[databinding] Fix databinding templates and resources for AndroidX

AFAICT, the AndroidX flag isn't respected anywhere; instead, it is just
hard-coded as false here. This flips it to true. Additionally, this
requires a change in the template. If this actually does need to be
customizable, I can wire up some of the flags accordingly. But, given
that data binding just didn't work on any platform (without the previous
commit), I can't imagine it is too controversial to set androidx=true.

Additionally, the shell command run to fix databinding compiled
resources was not cross-platform:

* BSD `head` won't take a negative int as its argument (GNU does).
    The better way to accomplish this goal here (listing all files in
    the archive) is just to use `zipinfo(1)`. `zipinfo -1` shows in its
    man page to be intended for exactly this purpose.
* BSD `sed` requires passsing an argument to the `-i` flag for a file
    extension to use when writing a back-up. A file without a back-up
    must be explicitly signaled by using an empty argument, i.e.
    `sed -i '' file`. However, a spaced argument to `-i` on GNU sed is
    interpreted as the next positional argument to `sed`, which is an
    error. The only cross-platform way to accomplish this appears to be
    to combine it into one like `-i.bak`. This then needs to be removed.
    (From [StackOverflow](https://stackoverflow.com/a/22084103/1819790))
* Using `sed` to change a string in an otherwise binary file may require
    changing the localization variables. At least, it does on standard
    BSD/macOS: otherwise, `sed` assumes files are encoded as text, and
    the class files contain invalid bytes. `LC_ALL` overrides all
    categories not set.

Author: pswaminathan

.bazelrc

@@ -1 +1,2 @@
-common --java_runtime_version=17
+common --java_runtime_version=remotejdk_17
+common --tool_java_runtime_version=remotejdk_17

rules/busybox.bzl

@@ -978,6 +978,7 @@ def _process_databinding(
     args.add_all(res_dirs, before_each = "--resource_root")
     args.add("--dataBindingInfoOut", out_databinding_info)
     args.add("--appId", java_package)
+    args.add("--useDataBindingAndroidX", "true")
 
     _set_warning_level(ctx, args)
 

rules/data_binding.bzl

@@ -67,7 +67,7 @@ def _gen_sources(ctx, output_dir, java_package, deps, layout_info, data_binding_
     args.add("-classInfoOut", class_info)
     args.add("-sourceOut", srcjar)
     args.add("-zipSourceOutput", "true")
-    args.add("-useAndroidX", "false")
+    args.add("-useAndroidX", "true")
 
     if deps:
         if type(deps[0].class_infos) == "depset":
@@ -250,11 +250,11 @@ def _process(
     if defines_resources:
         # Outputs of the Data Binding annotation processor.
         br_out = ctx.actions.declare_file(
-            output_dir + "bin-files/%s-br.bin" % java_package,
+            output_dir + "bin-files/%s--br.bin" % java_package,
         )
         db_info[_JAVA_ANNOTATION_PROCESSOR_ADDITIONAL_OUTPUTS].append(br_out)
         setter_store_out = ctx.actions.declare_file(
-            output_dir + "bin-files/%s-setter_store.json" % java_package,
+            output_dir + "bin-files/%s--setter_store.json" % java_package,
         )
         db_info[_JAVA_ANNOTATION_PROCESSOR_ADDITIONAL_OUTPUTS].append(
             setter_store_out,

rules/data_binding_annotation_template.txt

@@ -1,15 +1,13 @@
 package android.databinding.layouts;
 
-import android.databinding.BindingBuildInfo;
+import androidx.databinding.BindingBuildInfo;
 
 /**
  * Template for the file that feeds data binding's annotation processor. The
  * processor reads the values set here to generate .java files that link XML
  * data binding declarations (from layoutInfoDir) to app code.
  */
-@BindingBuildInfo(
-    buildId="not_used_here" // Adds incrementality, which Bazel already supports
-)
+@BindingBuildInfo
 public class DataBindingInfo {
   /* This only exists for annotation processing. */
 }

rules/resources.bzl

@@ -381,7 +381,7 @@ OUT_DIR=$(mktemp -d)
 CUR_PWD=$(pwd)
 
 if zipinfo -t "$1"; then
-    ORDERED_LIST=`(unzip -l "$1" | sed -e '1,3d' | head -n -2 | tr -s " " | cut -d " " -f5)`
+    ORDERED_LIST=`(zipinfo -1 "$1" | sort)`
 
     unzip -q "$1" -d "$IN_DIR"
 
@@ -390,7 +390,8 @@ if zipinfo -t "$1"; then
     for FILE in $ORDERED_LIST; do
         cd "$IN_DIR"
         if [ -f "$FILE" ]; then
-            sed -i 's/Databinding\\-processed\\-resources/databinding\\-processed\\-resources/g' "$FILE"
+            LC_ALL=C sed -i.bak 's/Databinding\\-processed\\-resources/databinding\\-processed\\-resources/g' "$FILE"
+            rm "${FILE}.bak"
             NEW_NAME=`echo "$FILE" | sed 's/Databinding\\-processed\\-resources/databinding\\-processed\\-resources/g' | sed 's#'"$IN_DIR"'/##g'`
             mkdir -p `dirname "$OUT_DIR/$NEW_NAME"` && touch "$OUT_DIR/$NEW_NAME"
             cp -p "$FILE" "$OUT_DIR/$NEW_NAME"

src/tools/java/com/google/devtools/build/android/AndroidResourceProcessor.java

@@ -305,7 +305,7 @@ static Path processDataBindings(
 
     ProcessXmlOptionsWrapper options = new ProcessXmlOptionsWrapper();
     options.setAppId(packagePath);
-    options.setResInput(inputResourcesDir.toFile());
+    options.setResInput(inputResourcesDir.toFile().getAbsoluteFile());
     options.setResOutput(processedResourceDir.toFile());
     options.setLayoutInfoOutput(dataBindingInfoOut.toFile());
     options.setUseAndroidX(useDataBindingAndroidX);