Skip to content

MI launcher doesn't pass adb path, resulting in error if adb is not at /usr/bin/adb #349

@pswaminathan

Description

@pswaminathan

MI launcher args:

args = {
"is_cmd": str(ctx.attr._mi_is_cmd).lower(),
"manifest_package_name_path": getattr(manifest_package_name_path, path_type),
}
if splits:
args["splits"] = [getattr(s, path_type) for s in splits]
args["java_home"] = utils.host_jvm_path(ctx)
args["studio_deployer"] = getattr(ctx.file._studio_deployer, path_type)
args["use_adb_root"] = str(use_adb_root).lower()
args["use_studio_deployer"] = str(use_studio_deployer).lower()
if test_data:
args["data_files"] = ",".join([f.short_path for f in test_data])
if test_apk:
args["test_apk"] = test_apk.path
if deploy_info_pb:
args["deploy_info"] = getattr(deploy_info_pb, path_type)
utils.create_flag_file(ctx, out_launcher_flags, **args)

These do not pass the adb path, resulting in falling back to the default:

adbPath = flag.String("adb", "/usr/bin/adb", "Path to the adb binary to use with mobile-install.")

If adb is not installed at /usr/bin/adb, mobile install fails with "no such file or directory".

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions