Skip to content

add inquirer option to set pullPolicy #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add inquirer option to set pullPolicy #639

wants to merge 2 commits into from

Conversation

@willcl-ark
Copy link
Contributor

  • add inquirer option to set pullPolicy
  • ask follow-up questions in order. Previous selecting "other" meant waiting until later in the question phase before you were asked how many "other" actually meant.
    • Use inquirer shortcut functions for all questions to simplify and allow intermediate questions in order.

@willcl-ark willcl-ark force-pushed the inquire-pull-policy branch 2 times, most recently from fc5f1c1 to d0d2bf4 Compare October 8, 2024 12:41
@willcl-ark
Copy link
Contributor Author

Any objections to this? I'd like to merge, especially for the second commit.

@pinheadmz @m3dwards @mplsgrant

@mplsgrant
Copy link
Collaborator

mplsgrant commented Oct 10, 2024 •
edited
Loading

Will the first commit pull images every time we helm? It seems like doing version numbers on the images might let us get the newest version without Always pulling.

Edit: Oh, I see it defaults to "no". That seems fine.

mplsgrant
mplsgrant reviewed Oct 10, 2024
View reviewed changes
mplsgrant
mplsgrant reviewed Oct 10, 2024
View reviewed changes
@willcl-ark
Copy link
Contributor Author

Will the first commit pull images every time we helm? It seems like doing version numbers on the images might let us get the newest version without Always pulling.

Edit: Oh, I see it defaults to "no". That seems fine.

Yeah, I guess I could technically drop this commit now that we have actual version numbers on the vuln images... I still think it's kinda useful though to fetch new versions automagically if desired (and if not you just enter right past it)

@mplsgrant
Copy link
Collaborator

Yeah, I guess I could technically drop this commit now that we have actual version numbers on the vuln images... I still think it's kinda useful though to fetch new versions automagically if desired (and if not you just enter right past it)

Agree. ACK 711156a

@willcl-ark willcl-ark mentioned this pull request Mar 11, 2025
Merged
@willcl-ark
Copy link
Contributor Author

willcl-ark commented Mar 11, 2025 •
edited by bdp-DrahtBot
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #707 (warnet init: add metricsExport:true if grafana is selected by pinheadmz)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@bdp-DrahtBot bdp-DrahtBot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mplsgrant mplsgrant mplsgrant left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@willcl-ark @mplsgrant