[ktor] Follow redirects is not disabled

[sunkup]

Following redirects is disabled, but it actually still works.

Try using an URL shortener like kutt.it for the ics calendar file address. ICSx5 will follow the redirect and add the subscription with the shortened URL.

@ArnyminerZ What is the actual reason we want to disallow following redirects in the first place? Could we not simply allow that?

Disabled (not working) here:

icsx5/app/src/main/java/at/bitfire/icsdroid/AppHttpClient.kt

Lines 63 to 69 in 576e861

	config {
	followRedirects(false)
	connectTimeout(20, TimeUnit.SECONDS)
	readTimeout(60, TimeUnit.SECONDS)
	sslSocketFactory(sslContext.socketFactory, certManager)
	hostnameVerifier(certManager.HostnameVerifier(OkHostnameVerifier))
	}

We can probably disable it properly (if we want to) by setting followRedirects = false for all engines.

[ArnyminerZ]

What is the actual reason we want to disallow following redirects in the first place? Could we not simply allow that?

I actually don't know 😅 I guess it was a copy-paste thing. But I agree that we could be following redirects without any issues.

[ArnyminerZ]

I think I will just remove:

- followRedirects(false)

[sunkup]

You will need to remove the followRedirects = false in the else branch too then 👍

[ArnyminerZ]

Should we do this in #685 or in a separate PR? I'm now thinking that it's better to do it in a separate one, just for the changelog

[sunkup]

Yes, please create a new PR.

[sunkup]

I actually don't know 😅 I guess it was a copy-paste thing. But I agree that we could be following redirects without any issues.

I think it might be due to redirects breaking at some point (ppl keep them for years) and then users reporting that as faulty ICSx5 behaviour. Maybe we should just leave them disabled for now and concentrate on fixing ktor and Nav3 :)

[ArnyminerZ]

Actually, we should keep redirects enabled, or get rid of CalendarFetcher.onRedirect. I think the best thing is to just make sure redirects are disabled, and therefore handled by CalendarFetcher.