-
-
Notifications
You must be signed in to change notification settings - Fork 477
Implement proposal nonextensible-applies-to-private #4511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement proposal nonextensible-applies-to-private #4511
Conversation
Test262 conformance changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4511 +/- ##
===========================================
+ Coverage 47.24% 57.48% +10.23%
===========================================
Files 476 504 +28
Lines 46892 57873 +10981
===========================================
+ Hits 22154 33268 +11114
+ Misses 24738 24605 -133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4e040c4 to
2540fb2
Compare
2540fb2 to
e010f53
Compare
HalidOdat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just some minor nitpicks 😄
|
Note that this changed slightly in tc39/proposal-nonextensible-applies-to-private@52e3ccc :) |
cdcd089 to
d804fd7
Compare
Implements the
nonextensible-applies-to-privateproposal.Since it's such a small change and it's already on stage 3, I decided to not gate this behind the experimental feature.