Skip to content

Conversation

@jedel1043
Copy link
Member

Implements the nonextensible-applies-to-private proposal.

Since it's such a small change and it's already on stage 3, I decided to not gate this behind the experimental feature.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,747 50,747 0
Passed 47,966 47,966 0
Ignored 1,971 1,971 0
Failed 810 810 0
Panics 0 0 0
Conformance 94.52% 94.52% 0.00%

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.48%. Comparing base (6ddc2b4) to head (d804fd7).
⚠️ Report is 611 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/object/operations.rs 6.66% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4511       +/-   ##
===========================================
+ Coverage   47.24%   57.48%   +10.23%     
===========================================
  Files         476      504       +28     
  Lines       46892    57873    +10981     
===========================================
+ Hits        22154    33268    +11114     
+ Misses      24738    24605      -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 force-pushed the implement-nonextensible-applies-to-private branch from 4e040c4 to 2540fb2 Compare October 31, 2025 03:38
@jedel1043 jedel1043 force-pushed the implement-nonextensible-applies-to-private branch from 2540fb2 to e010f53 Compare November 14, 2025 01:35
@jedel1043 jedel1043 marked this pull request as ready for review November 14, 2025 01:36
@jedel1043 jedel1043 added enhancement New feature or request Internal Category for changelog labels Nov 14, 2025
@jedel1043 jedel1043 added this to the v1.0.0 milestone Nov 14, 2025
@jedel1043 jedel1043 requested a review from a team November 14, 2025 02:06
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some minor nitpicks 😄

@linusg
Copy link
Contributor

linusg commented Nov 25, 2025

Note that this changed slightly in tc39/proposal-nonextensible-applies-to-private@52e3ccc :)

@jedel1043 jedel1043 force-pushed the implement-nonextensible-applies-to-private branch from cdcd089 to d804fd7 Compare December 8, 2025 02:32
@jedel1043 jedel1043 enabled auto-merge December 8, 2025 02:33
@jedel1043 jedel1043 added this pull request to the merge queue Dec 8, 2025
Merged via the queue into boa-dev:main with commit f707d11 Dec 8, 2025
18 checks passed
@jedel1043 jedel1043 deleted the implement-nonextensible-applies-to-private branch December 8, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Internal Category for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants