Add CalDAV calendar support for multiple providers #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
What do you think about moving Calendar creation to separate module, so you shouldn't know anything about provider inside the commands logic? |
Collaborator
|
i am thinking about something like getAllCals that return array of CalendarProvider |
Collaborator
|
All other aspects appear satisfactory. |
Owner
Author
|
Not quiet sure about quality but does it look like you're talking about? |
Collaborator
|
yes the idea is correct, i left a comment about calendar provider, it may simplify the interface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@L0ndra check out the first (and dirty approach) for caldav support.
It is NOT well tested and should be treated as a dirty initial thoughts about not-only-google refactoring