examples: C++11: Use using instead of typedef #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murraycu
force-pushed
the
develop-murrayc-examples-modern-cpp-attempt2c
branch
from
0d102e6 to
2fb6e02
Compare
Contributor
|
I'll wait until the merge conflicts have been resolved before I review. |
murraycu
force-pushed
the
develop-murrayc-examples-modern-cpp-attempt2c
branch
from
2fb6e02 to
dadac90
Compare
Contributor
Author
Done. |
murraycu
force-pushed
the
develop-murrayc-examples-modern-cpp-attempt2c
branch
from
dadac90 to
36e484c
Compare
murraycu
force-pushed
the
develop-murrayc-examples-modern-cpp-attempt2c
branch
from
36e484c to
90b7f5f
Compare
murraycu
force-pushed
the
develop-murrayc-examples-modern-cpp-attempt2c
branch
from
90b7f5f to
35f6a2d
Compare
Contributor
Author
|
@jeremy-murphy In case this isn´t showing up on some radar for you, I am still hoping you can review this, please. |
|
This PR looks very good to me, a nice step towards modernizing the code base. I hope it can be merged soon. |
Contributor
|
Thanks for the big improvement! Now please tell me that you didn't do this manually. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.