Added filter to remove all non-static boostlook.css on library docs (#1684) (#1685)

daveoconnor · web-flow · commit 8e27b66d9389 · 2025-03-07T11:41:06.000-08:00
diff --git a/core/htmlhelper.py b/core/htmlhelper.py
@@ -148,6 +148,7 @@ def modernize_legacy_page(
     head_selector="head",
     insert_body=True,
     original_docs_type=None,
+    skip_replace_boostlook=False,
     show_footer=True,
     show_navbar=True,
 ):
@@ -177,6 +178,8 @@ def modernize_legacy_page(
             tag.attrs.pop("class")
 
     result = convert_name_to_id(result)
+    if not skip_replace_boostlook:
+        result = remove_library_boostlook(result)
 
     # Use the base HTML to later extract the <head> and (part of) the <body>
     placeholder = BeautifulSoup(base_html, "html.parser")
@@ -291,6 +294,17 @@ def convert_name_to_id(soup):
     return soup
 
 
+def remove_library_boostlook(soup):
+    for tag in soup.find_all("link"):
+        if (
+            tag.get("href").endswith("boostlook.css")
+            and tag.get("href") != "/static/css/boostlook.css"
+        ):
+            tag.decompose()
+
+    return soup
+
+
 def format_nested_lists(soup):
     """Flattens nested lists"""
     try:
diff --git a/core/views.py b/core/views.py
@@ -34,7 +34,11 @@
     get_s3_client,
 )
 from .constants import SourceDocType
-from .htmlhelper import modernize_legacy_page, convert_name_to_id
+from .htmlhelper import (
+    modernize_legacy_page,
+    convert_name_to_id,
+    remove_library_boostlook,
+)
 from .markdown import process_md
 from .models import RenderedContent
 from .tasks import (
@@ -468,11 +472,12 @@ def process_content(self, content):
         )
 
         context["hide_footer"] = True
-        context["skip_use_boostbook_v2"] = "/antora/" in self.kwargs.get("content_path")
+        context["skip_use_boostlook"] = "/antora/" in self.kwargs.get("content_path")
         if source_content_type == SourceDocType.ASCIIDOC:
             extracted_content = content.decode(chardet.detect(content)["encoding"])
             soup = BeautifulSoup(extracted_content, "html.parser")
             soup = convert_name_to_id(soup)
+            soup = remove_library_boostlook(soup)
             soup.find("head").append(
                 soup.new_tag("script", src=f"{STATIC_URL}js/theme_handling.js")
             )
@@ -492,6 +497,7 @@ def process_content(self, content):
                 insert_body=insert_body,
                 head_selector=head_selector,
                 original_docs_type=SourceDocType.ANTORA,
+                skip_replace_boostlook=context["skip_use_boostlook"],
                 show_footer=False,
                 show_navbar=False,
             )
diff --git a/templates/docs_libs_placeholder.html b/templates/docs_libs_placeholder.html
@@ -4,7 +4,9 @@
 {% block extra_head %}
   <link href="{% static 'css/styles.css' %}" rel="stylesheet" />
   <link rel="preload" data-modernizer="boost-legacy-docs-extra-head" href="{% static 'css/fonts.css' %}" rel="stylesheet" />
-  <link rel="preload" data-modernizer="boost-legacy-docs-extra-head" href="{% static 'css/boostlook.css' %}" rel="stylesheet" />
+  {% if not skip_use_boostlook %}
+    <link rel="preload" data-modernizer="boost-legacy-docs-extra-head" href="{% static 'css/boostlook.css' %}" rel="stylesheet" />
+  {% endif %}
   {% comment %}These style tweaks ensure that legacy doc pages are rendered decently. Specifically, the <img /> tag is heavily used in nav bar for tutorial navigation.<style data-modernizer="boost-legacy-docs-extra-head">
                                                                                                                                                                          img {
                                                                                                                                                                            display: inline-block;
