Added support for /lib/{LIBRARY} to redirect to library detail page (#1939)

Author: daveoconnor

config/urls.py

@@ -26,14 +26,15 @@
     RedirectToDocsView,
     RedirectToHTMLDocsView,
     RedirectToHTMLToolsView,
-    RedirectToLibraryView,
+    RedirectToLibrariesView,
     RedirectToReleaseView,
     RedirectToToolsView,
     StaticContentTemplateView,
     UserGuideTemplateView,
     BoostDevelopmentView,
     ModernizedDocsView,
     QRCodeView,
+    RedirectToLibraryDetailView,
 )
 from libraries.api import LibrarySearchView
 from libraries.views import (
@@ -381,6 +382,11 @@
         ),
     ]
     + [
+        re_path(
+            r"^lib/(?P<library_slug>[^/]+)/?$",
+            RedirectToLibraryDetailView.as_view(),
+            name="redirect-to-library-view",
+        ),
         # Redirects for old boost.org urls.
         re_path(
             r"^libs/(?P<libname>[^/]+)/(?P<path>.*)/?$",
@@ -404,7 +410,7 @@
         ),
         re_path(
             r"^doc/libs/(?P<requested_version>[^/]+)/?$",
-            RedirectToLibraryView.as_view(),
+            RedirectToLibrariesView.as_view(),
             name="redirect-to-library-page",
         ),
         re_path(

core/tests/test_views.py

@@ -319,3 +319,18 @@ def test_qrc_logs_plausible_error_but_still_redirects(tp, caplog):
     tp.response_302(res)
     assert res["Location"] == "/library/"
     assert any("Plausible event post failed" in r.message for r in caplog.records)
+
+
+def test_redirect_to_library_detail_view(tp):
+    """Test that /lib/<library_slug>/ redirects to library detail page with prioritized version."""
+    response = tp.get("redirect-to-library-view", library_slug="algorithm")
+    tp.response_302(response)
+    assert response["Location"] == "/library/latest/algorithm/"
+
+
+def test_redirect_to_library_detail_view_with_cookie(tp):
+    """Test that /lib/<library_slug>/ redirects using version from cookie."""
+    tp.client.cookies["boost_version"] = "boost-1-86-0"
+    response = tp.get("redirect-to-library-view", library_slug="algorithm")
+    tp.response_302(response)
+    assert response["Location"] == "/library/1.86.0/algorithm/"

core/views.py

@@ -28,7 +28,11 @@
 
 from config.settings import ENABLE_DB_CACHE
 from libraries.constants import LATEST_RELEASE_URL_PATH_STR
-from libraries.utils import legacy_path_transform, generate_canonical_library_uri
+from libraries.utils import (
+    legacy_path_transform,
+    generate_canonical_library_uri,
+    get_prioritized_version,
+)
 from versions.models import Version
 
 from .asciidoc import convert_adoc_to_html
@@ -887,7 +891,22 @@ def get(self, request, requested_version):
         return HttpResponseRedirect(new_path)
 
 
-class RedirectToLibraryView(BaseRedirectView):
+class RedirectToLibraryDetailView(BaseRedirectView):
+    """View to redirect to a library's detail page"""
+
+    def get(self, request, library_slug):
+        return redirect(
+            reverse(
+                "library-detail",
+                kwargs={
+                    "library_slug": library_slug,
+                    "version_slug": get_prioritized_version(request),
+                },
+            )
+        )
+
+
+class RedirectToLibrariesView(BaseRedirectView):
     """View to redirect to a versioned libraries page."""
 
     def get(self, request, requested_version):

libraries/utils.py

@@ -124,7 +124,7 @@ def get_prioritized_version(request):
     """
     url_version = get_version_from_url(request)
     cookie_version = get_version_from_cookie(request)
-    default_version = None
+    default_version = LATEST_RELEASE_URL_PATH_STR
     return url_version or cookie_version or default_version