Release v1.0.1 breaks Nexus compatibility

[benyamin-codez]

Version 1.0.1 breaks Nexus (Kodi v20) compatibility due to down-level python version (< v3.10) and missing window reference.

Fixed with the following:

--- ./a/utilities.py
+++ ./b/utilities.py
@@ -1,4 +1,5 @@
+from __future__ import annotations
 import json
 import re
 import xbmc
 import xbmcgui
@@ -7,9 +8,9 @@
 from urllib.parse import unquote
 from typing import Any
 
 # noinspection PyPackages
-from .constants import ADDON
+from .constants import ADDON, WEATHER_WINDOW
 # noinspection PyPackages
 from .logger import Logger

Untested on Omega or Piers...

Thanks for the great plugin, Jeremy.

Best regards,
Ben

[benyamin-codez]

Before I lose it, this was the initial log snippet:

error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
    Error Type: <class 'TypeError'>
    Error Contents: unsupported operand type(s) for |: 'type' and 'NoneType'
    Traceback (most recent call last):
      File "/home/osmc/.kodi/addons/weather.ozweather/default.py", line 5, in <module>
        from resources.lib import ozweather
      File "/home/osmc/.kodi/addons/weather.ozweather/resources/lib/ozweather.py", line 5, in <module>
        from .forecast import *
      File "/home/osmc/.kodi/addons/weather.ozweather/resources/lib/forecast.py", line 2, in <module>
        from bossanova808.utilities import *
      File "/home/osmc/.kodi/addons/script.module.bossanova808/resources/lib/bossanova808/utilities.py", line 16, in <module>
        def set_property(window: xbmcgui.Window, name: str, value: str | None = None) -> None:
    TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
    -->End of Python script error report<--

[bossanova808]

Am currently juggling updates to about 15 addons at the same time so yep looks like I missed something here! Surprised the Kodi gatekeepers didn't flag this on review to be honest.

Fix submitted here - xbmc/repo-scripts#2767

For anyone else seeing this, if you don't want to wait, there is an updated version of this module here:
https://filebin.net/lrigj24mk9ehrhu7

...that can be manually copied over your existing script.module.bossanova808 in your addons folder.

Reboot and things should work again (and the proper fix will follow once the Kodi mods approve it).

[benyamin-codez]

Thanks Jeremy.
I see you've also added a get_addon_version() helper to utilities.py. Is that also needed for OzWeather v2.1.6...?
Did you want to leave this open until the fix hits the Kodi repo?

[bossanova808]

No, that's actually for the skin patcher (a later version that will come out once that is in).

I figure I might as well get other things in there, if helpful, if they're going to review it anyway. (Might yet be more depending on how other things I am doing go...)

And yes, best to leave this open for anyone else having the issue, I think...I'll close it once the fix is in.

[bossanova808]

Fix is in the Kodi repo now so should soon arrive automatically for anyone affected.

[benyamin-codez]

Jeremy, I note this affects Nexus also - at least on legacy OSMC kit (Python is v3.9.2).
Does your v1.0.2 script module need to be pushed to the Nexus branch also?

[bossanova808]

It was included in the Matrix branch (all my addons are Matrix+, except Switchback which is Nexus+ due to a dependency). As far as I understand it that flows through then to all other later branches, so to speak.

I tested against a clean Matrix install, directly from the Kodi repo - all good. So all should, in theory, be working fine on Nexus too, I would think. What error did you actually get and are you using the from-repo version or your own fixed one? Your fix wasn't quite enough for some of my other addons, and I also included a bunch of extra things I had in the pipeline so make sure you're using the from repo version.

Maybe post a debug log?

[benyamin-codez]

It was included in the Matrix branch (all my addons are Matrix+, except Switchback which is Nexus+ due to a dependency). As far as I understand it that flows through then to all other later branches, so to speak.

Yeah, it is certainly appearing on my other Kodi boxes... 8^d

Looks like the OSMC mirrors haven't synced yet. I'll install it manually rather than wait...

[bossanova808]

I've had a view add-on issue reports due to OSMC sluggishness over the years, as it happens. I am sure the current version will come along in due course..