Fix some Python code style issues #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it's being imported one place in the code, it's not actually being used anywhere.
`flake8` output prior to this commit: ``` > flake8 --ignore D,E402,E501,F841 *.py client.py:35:3: E111 indentation is not a multiple of four client.py:45:3: E111 indentation is not a multiple of four client.py:55:7: E111 indentation is not a multiple of four client.py:56:7: E111 indentation is not a multiple of four client.py:57:7: E111 indentation is not a multiple of four client.py:58:7: E111 indentation is not a multiple of four client.py:59:7: E111 indentation is not a multiple of four client.py:61:3: E111 indentation is not a multiple of four client.py:64:3: E111 indentation is not a multiple of four client.py:81:3: E111 indentation is not a multiple of four client.py:97:3: E111 indentation is not a multiple of four client.py:114:3: E111 indentation is not a multiple of four client.py:134:3: E111 indentation is not a multiple of four client.py:154:7: E111 indentation is not a multiple of four client.py:157:3: E111 indentation is not a multiple of four client.py:174:3: E111 indentation is not a multiple of four gciq.py:40:1: E101 indentation contains mixed spaces and tabs gciq.py:40:1: W191 indentation contains tabs gciq.py:40:2: E117 over-indented gciq.py:41:1: W191 indentation contains tabs gciq.py:42:1: W191 indentation contains tabs gciq.py:42:3: E117 over-indented gciq.py:43:1: W191 indentation contains tabs gciq.py:47:1: W191 indentation contains tabs gciq.py:47:2: E117 over-indented gciq.py:48:1: W191 indentation contains tabs gciq.py:48:3: E117 over-indented gciq.py:49:1: W191 indentation contains tabs gciq.py:50:1: W191 indentation contains tabs gciq.py:50:3: E117 over-indented gciq.py:51:1: W191 indentation contains tabs gciq.py:52:1: W191 indentation contains tabs gciq.py:52:3: E117 over-indented gciq.py:53:1: W191 indentation contains tabs gciq.py:54:1: W191 indentation contains tabs gciq.py:54:3: E117 over-indented gciq.py:58:1: W191 indentation contains tabs gciq.py:58:2: E117 over-indented gciq.py:62:1: W191 indentation contains tabs gciq.py:62:2: E117 over-indented gciq.py:63:1: W191 indentation contains tabs gciq.py:64:1: W191 indentation contains tabs gciq.py:65:1: W191 indentation contains tabs gciq.py:66:1: W191 indentation contains tabs gciq.py:66:3: E117 over-indented gciq.py:67:1: W191 indentation contains tabs gciq.py:71:1: W191 indentation contains tabs gciq.py:71:2: E117 over-indented gciq.py:72:1: W191 indentation contains tabs gciq.py:72:3: E117 over-indented gciq.py:73:1: W191 indentation contains tabs gciq.py:74:1: W191 indentation contains tabs gciq.py:78:1: W191 indentation contains tabs gciq.py:78:2: E117 over-indented gciq.py:79:1: W191 indentation contains tabs gciq.py:80:1: W191 indentation contains tabs gciq.py:81:1: W191 indentation contains tabs gciq.py:82:1: W191 indentation contains tabs gciq.py:83:1: W191 indentation contains tabs gciq.py:84:1: W191 indentation contains tabs gciq.py:86:1: W191 indentation contains tabs gciq.py:87:1: W191 indentation contains tabs gciq.py:89:1: W191 indentation contains tabs gciq.py:90:1: W191 indentation contains tabs gciq.py:92:1: W191 indentation contains tabs gciq.py:93:1: W191 indentation contains tabs gciq.py:94:1: W191 indentation contains tabs gciq.py:95:1: W191 indentation contains tabs gciq.py:96:1: W191 indentation contains tabs gciq.py:97:1: W191 indentation contains tabs gciq.py:98:1: W191 indentation contains tabs gciq.py:99:1: W191 indentation contains tabs gciq.py:101:1: W191 indentation contains tabs gciq.py:102:1: W191 indentation contains tabs gciq.py:103:1: W191 indentation contains tabs gciq.py:104:1: W191 indentation contains tabs gciq.py:105:1: W191 indentation contains tabs gciq.py:106:1: W191 indentation contains tabs gciq.py:107:1: W191 indentation contains tabs gciq.py:108:1: W191 indentation contains tabs gciq.py:109:1: W191 indentation contains tabs gciq.py:109:61: E226 missing whitespace around arithmetic operator gciq.py:110:1: W191 indentation contains tabs gciq.py:111:1: W191 indentation contains tabs gciq.py:112:1: W191 indentation contains tabs gciq.py:113:1: W191 indentation contains tabs gciq.py:114:1: W191 indentation contains tabs gciq.py:115:1: W191 indentation contains tabs gciq.py:116:1: W191 indentation contains tabs gciq.py:117:1: W191 indentation contains tabs gciq.py:118:1: W191 indentation contains tabs gciq.py:122:1: W191 indentation contains tabs gciq.py:122:2: E117 over-indented gciq.py:123:1: W191 indentation contains tabs gciq.py:124:1: W191 indentation contains tabs gciq.py:125:1: W191 indentation contains tabs gciq.py:125:3: E117 over-indented gciq.py:126:1: W191 indentation contains tabs gciq.py:127:1: W191 indentation contains tabs gciq.py:131:1: W191 indentation contains tabs gciq.py:131:2: E117 over-indented gciq.py:132:1: W191 indentation contains tabs gciq.py:136:1: W191 indentation contains tabs gciq.py:136:2: E117 over-indented gciq.py:137:1: W191 indentation contains tabs gciq.py:138:1: W191 indentation contains tabs gciq.py:138:3: E117 over-indented gciq.py:139:1: W191 indentation contains tabs gciq.py:139:4: E117 over-indented gciq.py:140:1: W191 indentation contains tabs gciq.py:141:1: W191 indentation contains tabs gciq.py:142:1: W191 indentation contains tabs gciq.py:146:1: W191 indentation contains tabs gciq.py:146:2: E117 over-indented gciq.py:147:1: W191 indentation contains tabs gciq.py:148:1: W191 indentation contains tabs gciq.py:149:1: W191 indentation contains tabs gciq.py:149:3: E117 over-indented gciq.py:150:1: W191 indentation contains tabs gciq.py:151:1: W191 indentation contains tabs gciq.py:151:3: E117 over-indented gciq.py:152:1: W191 indentation contains tabs gciq.py:152:4: E117 over-indented gciq.py:154:1: W191 indentation contains tabs gciq.py:156:1: W191 indentation contains tabs gciq.py:157:1: W191 indentation contains tabs gciq.py:158:1: W191 indentation contains tabs gciq.py:159:1: W191 indentation contains tabs gciq.py:160:1: W191 indentation contains tabs gciq.py:160:3: E117 over-indented gciq.py:161:1: W191 indentation contains tabs gciq.py:163:1: W191 indentation contains tabs gciq.py:164:1: W191 indentation contains tabs gciq.py:165:1: W191 indentation contains tabs gciq.py:166:1: W191 indentation contains tabs gciq.py:167:1: W191 indentation contains tabs gciq.py:167:3: E117 over-indented gciq.py:168:1: W191 indentation contains tabs gciq.py:170:1: W191 indentation contains tabs gciq.py:171:1: W191 indentation contains tabs gciq.py:172:1: W191 indentation contains tabs gciq.py:173:1: W191 indentation contains tabs gciq.py:173:3: E117 over-indented gciq.py:174:1: W191 indentation contains tabs gciq.py:174:4: E117 over-indented gciq.py:175:1: W191 indentation contains tabs gciq.py:176:1: W191 indentation contains tabs gciq.py:177:1: W191 indentation contains tabs gciq.py:178:1: W191 indentation contains tabs gciq.py:179:1: W191 indentation contains tabs gciq.py:180:1: W191 indentation contains tabs gciq.py:181:1: W191 indentation contains tabs gciq.py:182:1: W191 indentation contains tabs gciq.py:183:1: W191 indentation contains tabs gciq.py:184:1: W191 indentation contains tabs gciq.py:184:5: E117 over-indented gciq.py:186:1: W191 indentation contains tabs gciq.py:187:1: W191 indentation contains tabs gciq.py:187:5: E117 over-indented gciq.py:188:1: W191 indentation contains tabs gciq.py:188:6: E117 over-indented gciq.py:189:1: W191 indentation contains tabs gciq.py:191:1: E265 block comment should start with '# ' gciq.py:192:1: E265 block comment should start with '# ' gciq.py:193:1: E265 block comment should start with '# ' gciq.py:194:1: E265 block comment should start with '# ' gciq.py:195:1: E265 block comment should start with '# ' gciq.py:196:1: E265 block comment should start with '# ' gciq.py:198:1: W191 indentation contains tabs gciq.py:199:1: W191 indentation contains tabs gciq.py:200:1: W191 indentation contains tabs gciq.py:201:1: W191 indentation contains tabs gciq.py:201:3: E117 over-indented gciq.py:202:1: W191 indentation contains tabs gciq.py:206:1: W191 indentation contains tabs gciq.py:206:2: E117 over-indented gciq.py:207:1: W191 indentation contains tabs gciq.py:208:1: W191 indentation contains tabs gciq.py:209:1: W191 indentation contains tabs gciq.py:210:1: W191 indentation contains tabs gciq.py:211:1: W191 indentation contains tabs gciq.py:211:3: E117 over-indented gciq.py:212:1: W191 indentation contains tabs gciq.py:213:1: W191 indentation contains tabs gciq.py:214:1: W191 indentation contains tabs gciq.py:215:1: W191 indentation contains tabs gciq.py:216:1: W191 indentation contains tabs gciq.py:216:4: E117 over-indented gciq.py:218:1: W191 indentation contains tabs gciq.py:219:1: W191 indentation contains tabs gciq.py:220:1: W191 indentation contains tabs gciq.py:220:4: E117 over-indented gciq.py:221:1: W191 indentation contains tabs gciq.py:222:1: W191 indentation contains tabs gciq.py:222:5: E117 over-indented gciq.py:223:1: W191 indentation contains tabs gciq.py:224:1: W191 indentation contains tabs gciq.py:228:1: W191 indentation contains tabs gciq.py:228:2: E117 over-indented gciq.py:229:1: W191 indentation contains tabs gciq.py:230:1: W191 indentation contains tabs gciq.py:231:1: W191 indentation contains tabs gciq.py:231:3: E117 over-indented gciq.py:232:1: W191 indentation contains tabs gciq.py:233:1: W191 indentation contains tabs gciq.py:233:3: E117 over-indented gciq.py:234:1: W191 indentation contains tabs gciq.py:234:4: E117 over-indented gciq.py:236:1: W191 indentation contains tabs gciq.py:237:1: W191 indentation contains tabs gciq.py:238:1: W191 indentation contains tabs gciq.py:239:1: W191 indentation contains tabs gciq.py:239:3: E117 over-indented gciq.py:240:1: W191 indentation contains tabs gciq.py:241:1: W191 indentation contains tabs gciq.py:242:1: W191 indentation contains tabs gciq.py:246:1: W191 indentation contains tabs gciq.py:246:2: E117 over-indented gciq.py:247:1: W191 indentation contains tabs gciq.py:248:1: W191 indentation contains tabs gciq.py:248:3: E117 over-indented gciq.py:249:1: W191 indentation contains tabs gciq.py:250:1: W191 indentation contains tabs gciq.py:250:3: E117 over-indented gciq.py:251:1: W191 indentation contains tabs gciq.py:251:4: E117 over-indented gciq.py:253:1: W191 indentation contains tabs gciq.py:254:1: W191 indentation contains tabs gciq.py:255:1: W191 indentation contains tabs gciq.py:256:1: W191 indentation contains tabs gciq.py:257:1: W191 indentation contains tabs gciq.py:257:3: E117 over-indented gciq.py:258:1: W191 indentation contains tabs gciq.py:259:1: W191 indentation contains tabs gciq.py:260:1: W191 indentation contains tabs gciq.py:260:4: E117 over-indented gciq.py:262:1: W191 indentation contains tabs gciq.py:263:1: W191 indentation contains tabs gciq.py:264:1: W191 indentation contains tabs gciq.py:265:1: W191 indentation contains tabs gciq.py:266:1: W191 indentation contains tabs gciq.py:267:1: W191 indentation contains tabs gciq.py:267:5: E117 over-indented gciq.py:268:1: W191 indentation contains tabs gciq.py:269:1: W191 indentation contains tabs gciq.py:270:1: W293 blank line contains whitespace gciq.py:270:1: W191 indentation contains tabs gciq.py:271:1: W191 indentation contains tabs gciq.py:272:1: W191 indentation contains tabs gciq.py:273:1: W191 indentation contains tabs gciq.py:274:1: W191 indentation contains tabs gciq.py:275:1: W191 indentation contains tabs gciq.py:276:1: W191 indentation contains tabs gciq.py:277:1: W191 indentation contains tabs gciq.py:278:1: W191 indentation contains tabs gciq.py:279:1: W191 indentation contains tabs gciq.py:280:1: W191 indentation contains tabs gciq.py:281:1: W191 indentation contains tabs gciq.py:282:1: W191 indentation contains tabs gciq.py:282:5: E123 closing bracket does not match indentation of opening bracket's line gciq.py:283:1: W191 indentation contains tabs gciq.py:284:1: W191 indentation contains tabs gciq.py:284:5: E117 over-indented gciq.py:286:1: W191 indentation contains tabs gciq.py:287:1: W191 indentation contains tabs gciq.py:288:1: W191 indentation contains tabs gciq.py:289:1: W191 indentation contains tabs gciq.py:290:1: W191 indentation contains tabs gciq.py:290:4: E117 over-indented gciq.py:291:1: W191 indentation contains tabs gciq.py:292:1: W191 indentation contains tabs gciq.py:292:5: E117 over-indented gciq.py:296:1: W191 indentation contains tabs gciq.py:296:2: E117 over-indented gciq.py:297:1: W191 indentation contains tabs gciq.py:299:1: W191 indentation contains tabs gciq.py:300:1: W191 indentation contains tabs gciq.py:301:1: W191 indentation contains tabs gciq.py:302:1: W191 indentation contains tabs gciq.py:303:1: W191 indentation contains tabs gciq.py:304:1: W191 indentation contains tabs gciq.py:304:3: E117 over-indented gciq.py:305:1: W191 indentation contains tabs gciq.py:305:4: E117 over-indented gciq.py:306:1: W191 indentation contains tabs gciq.py:307:1: W191 indentation contains tabs gciq.py:309:1: W191 indentation contains tabs gciq.py:310:1: W191 indentation contains tabs gciq.py:311:1: W191 indentation contains tabs gciq.py:312:1: W191 indentation contains tabs gciq.py:312:3: E123 closing bracket does not match indentation of opening bracket's line gciq.py:314:1: W191 indentation contains tabs gciq.py:315:1: W191 indentation contains tabs gciq.py:315:3: E117 over-indented gciq.py:316:1: W191 indentation contains tabs gciq.py:317:1: W191 indentation contains tabs gciq.py:317:3: E117 over-indented gciq.py:318:1: W191 indentation contains tabs gciq.py:318:4: E117 over-indented gciq.py:320:1: W191 indentation contains tabs gciq.py:321:1: W191 indentation contains tabs gciq.py:321:3: E117 over-indented gciq.py:323:1: W191 indentation contains tabs gciq.py:324:1: W191 indentation contains tabs gciq.py:326:1: E305 expected 2 blank lines after class or function definition, found 1 gciq.py:327:1: W191 indentation contains tabs gciq.py:327:2: E117 over-indented gciq.py:328:1: W391 blank line at end of file ```
See also recommendation in PEP 394: https://www.python.org/dev/peps/pep-0394/#recommendation > […] code that needs to invoke the Python interpreter should not specify > `python`, but rather should specify either `python2` or `python3` (or the > more specific `python2.x` and `python3.x` versions; […]). Fixes brlcad#8
Using `/usr/bin/env python` is generally the preferred way to do Python shebang lines, and relying on `/usr/local/bin` seems too specific anyway—most users will likely have Python in `/usr/bin` (or "locally" in a virtual environment). See e.g., https://docs.python.org/2.7/tutorial/appendix.html
brlcad
requested changes
Feb 21, 2019
Owner
brlcad
left a comment
brlcad
left a comment
There was a problem hiding this comment.
Since python 3 is now supported, some of this is OBE and that support made the whitespace cleanup conflict hard. Can you redo those fixes off the latest? I already applied the env and bs4 changes too.
Owner
|
Also apologies -- had I noticed this pull request earlier, I would have merged it before doing the py3 fixes and whitespace wouldn't have become an issue. |
Contributor
|
On Python3 things just didn't work well for me -- switched to 2.7 and it
worked flawlessly
I will try to debug on Sunday night while i still have access to the site
…On 2/20/19 10:57 PM, Christopher Sean Morrison wrote:
Also apologies -- had I noticed this pull request earlier, I would
have merged it before doing the py3 fixes and whitespace wouldn't have
become an issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABaMPOrXqxb8JsoYJx0b3WMz5IRsjW4ks5vPhkSgaJpZM4bCg4Y>.
|
Owner
Sounds good. I only tested Python 3 on a Mac via brew (3.7.2.2) and it definitely worked for me, downloaded all tasks, attachments, etc., but I wouldn't be surprised with a different data set. The UTF-8 support in particular can be tricky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.