Skip to content

Commit c4ed3a6

Browse files
committed
easy fixes for Nick 08/29
1 parent ff65f8d commit c4ed3a6

File tree

2 files changed

+14
-18
lines changed

2 files changed

+14
-18
lines changed

cypress/e2e/hermes/hermes-upload.cy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('Hermes Upload', {retries: 0}, () => {
1010
cy.visit('/hermes/new', { timeout: 10000 });
1111
cy.get('#dataSetName').type('Cypress dataset');
1212
// cy.get('#genomeBuild').type('GRCh38').type('{enter}');
13-
cy.get('[data-cy="cohort"]').type('UKBio').type('{enter}');
13+
cy.get('#cohort').type('UKBiobank');
1414
cy.get('#contactPerson').type('Point of Contact');
1515
cy.get('#dataCollectionStart').type('2006/01/01');
1616
cy.get('[data-cy="sex"]').type('Male').type('{enter}');

pages/hermes/new.vue

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,7 @@ const genomeBuildOptions = ref([
154154
{ name: "GRCh38/hg38", value: "GRCh38/hg38" },
155155
{ name: "GRCh37/b37", value: "GRCh37/b37" },
156156
]);
157-
const cohortOptions = ref([
158-
{ name: "UK Biobank", value: "UK Biobank" },
159-
{ name: "23andMe", value: "23andMe" },
160-
{ name: "AncestryDNA", value: "AncestryDNA" }
161-
]);
157+
162158
const subjects = ref(0);
163159
const participants = ref(null);
164160
const sexProportion = ref(null);
@@ -414,24 +410,23 @@ async function uploadSubmit(){
414410
<Fieldset legend="Study Metadata">
415411
<div class="field">
416412
<label for="dataSetName">Dataset Name</label>
417-
<InputText v-tooltip="'e.g. “UKBB Heart Failure (female)'"
413+
<div v-tooltip="'e.g. “UKBB Heart Failure (female)”'">
414+
<InputText
418415
v-model="dataSetName"
419416
id="dataSetName" :class="{ 'p-invalid': errors.dataSetName }"
420417
aria-describedby="dataSetName-help"
421418
placeholder="Enter Dataset Name"
422-
/>
419+
/>
420+
</div>
423421
<small id="dataSetName-help" class="p-error">
424422
{{ errors.dataSetName }}
425423
</small>
426424
</div>
427425
<div class="field">
428426
<label for="cohort">Cohort</label>
429427
<div v-tooltip="'e.g. “UKBiobank”'">
430-
<Dropdown placeholder="Select Cohort" v-model="cohort" :options="cohortOptions" id="cohort" optionLabel="name"
431-
optionValue="value" :class="{ 'p-invalid': errors.cohort }"
432-
aria-describedby="cohort-help" data-cy="cohort"
433-
434-
/>
428+
<InputText v-model="cohort" id="cohort" :class="{ 'p-invalid': errors.cohort }"
429+
aria-describedby="cohort-help" />
435430
</div>
436431
<small id="cohort-help" class="p-error">
437432
{{ errors.cohort }}
@@ -490,11 +485,12 @@ async function uploadSubmit(){
490485
<Fieldset legend="Participants">
491486
<div class="field">
492487
<label for="phenotype">Phenotype</label>
493-
<InputText v-model="phenotype" id="phenotype" type="text"
494-
v-tooltip="'The phenotype description e.g. “all-cause heart failure'"
495-
aria-describedby="phenotype-help"
496-
:class="{ 'p-invalid': errors.phenotype }"
497-
/>
488+
<div v-tooltip="'The phenotype description e.g. “all-cause heart failure”'">
489+
<InputText v-model="phenotype" id="phenotype" type="text"
490+
aria-describedby="phenotype-help"
491+
:class="{ 'p-invalid': errors.phenotype }"
492+
/>
493+
</div>
498494
<small id="phenotype-help" class="p-error">
499495
{{ errors.phenotype }}
500496
</small>

0 commit comments

Comments
 (0)