Clarification about selectMany API

[7h3kk1d]

Looking at selectMany in the TableAPI
selectMany :: t1:Table * project:(r1:Row * n:Number -> t2:Table) * result:(r2:Row * r3:Row -> r4:Row) -> t2:Table

I'm wondering if the return value is supposed to be a t3: Table with the constraints adjusted to say that the t3 should have the same schema as r4.

The TS type-signature seems to be closer to that:

export let selectMany = <S1 extends STop, S2 extends STop, S3 extends STop>(t1: Table<S1>, project: (r1: Row<S1>, n: number) => Table<S2>, result: (r2: Row<S1>, r3: Row<S2>) => Row<S3>): Table<S3> => {

I also think it's based off of this linq entry it should have 3 row schema types.

[LuKuangChen]

Thanks for reporting the bug!

You're absolutely right—the return value should be t3:Table rather than t2: Table. Each name in a signature must be unique, and the current version incorrectly reuses t2. The final constraint in the type signature should also refer to t3, not t2.

I'll update the TableAPI shortly to fix this. Thanks again for pointing it out!