Remove vendored dsl-json #2253
Merged
Remove vendored dsl-json #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
lemnik
dismissed stale reviews from yousif-bugsnag and YYChen01988
via
834e695
lemnik
force-pushed
the
PLAT-14670/remove-dsljson
branch
from
5917c57 to
834e695
Compare
gingerbenw
approved these changes
Sep 15, 2025
YYChen01988
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Reduce the SDK size by replacing our vendored copy of dsl-json with a first-party JSON parser
Design
Our dsl-json code was largely used to parse JSON files for
OnSendCallbacks. The newJsonCollectionParserdireclty parses the UTF-8 bytes directly into Java collection classes (which is what we used dsl-json for).This approach allows us to:
Testing
Minor changes to existing tests, most code should be unaware of this change.
This PR does introduce some new fixtures to stress-test the JSON parsing.