feat: add handshakeTimeout to Http2Adapter's ConnectionManager #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
any updates? |
AlexV525
reviewed
Sep 21, 2025
AlexV525
reviewed
Sep 25, 2025
Comment on lines
143
to
145
| try { | ||
| stream.outgoingMessages.add(DataStreamMessage(data)); | ||
| } catch (_) {} |
Contributor
Author
There was a problem hiding this comment.
Eventually, I got a StateError: Bad state: Cannot add event after closing in Crashlytics. I can’t reproduce it locally — maybe it’s caused by some race condition, I’m not sure.
Member
There was a problem hiding this comment.
Let's revert until we have a clear path on how to reproduce and what we are fixing.
Contributor
Author
There was a problem hiding this comment.
Ok, sure
Should I add a TODO?
AlexV525
reviewed
Sep 28, 2025
Comment on lines
143
to
145
| try { | ||
| stream.outgoingMessages.add(DataStreamMessage(data)); | ||
| } catch (_) {} |
Member
There was a problem hiding this comment.
Let's revert until we have a clear path on how to reproduce and what we are fixing.
Co-authored-by: Alex Li <[email protected]> Signed-off-by: Ivan Elizarov <[email protected]>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
AlexV525
approved these changes
Oct 23, 2025
Member
AlexV525
left a comment
AlexV525
left a comment
There was a problem hiding this comment.
LGTM. Sorry for the long wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, like when ISP infrastructure is down or misconfigured, user may end up long-waiting for handshake to complete with further
HandshakeException. In my case it was around 1 minute which is huge. This PR adds an optional paramhandshakeTimeouttoConnectionManagerthat after all returns chains with this future in_RawSecureSocketNew Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)