Skip to content

Commit b849cb6

Browse files
authored
fix: dont fail on unresolved registry packages (#1888)
Similar to #1223 but for registry packages, let's users run `@swift_package//:resolve` without crashing with: ```sh ERROR: /private/var/tmp/_bazel_lpadron/0ee4409da52ac4ece68cb8fe68c1de00/external/rules_swift_package_manager+/swiftpkg/bzlmod/swift_deps.bzl:273:34: Traceback (most recent call last): File "/private/var/tmp/_bazel_lpadron/0ee4409da52ac4ece68cb8fe68c1de00/external/rules_swift_package_manager+/swiftpkg/bzlmod/swift_deps.bzl", line 315, column 43, in _swift_deps_impl _declare_pkgs_from_package( File "/private/var/tmp/_bazel_lpadron/0ee4409da52ac4ece68cb8fe68c1de00/external/rules_swift_package_manager+/swiftpkg/bzlmod/swift_deps.bzl", line 188, column 37, in _declare_pkgs_from_package _declare_pkg_from_dependency(dep, config_pkg, from_package, config_swift_package) File "/private/var/tmp/_bazel_lpadron/0ee4409da52ac4ece68cb8fe68c1de00/external/rules_swift_package_manager+/swiftpkg/bzlmod/swift_deps.bzl", line 273, column 34, in _declare_pkg_from_dependency id = dep.registry.pin.identity, Error: 'NoneType' value has no field or method 'identity' ```
1 parent 50ed554 commit b849cb6

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

swiftpkg/internal/pkginfos.bzl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -921,6 +921,9 @@ def _new_registry(pin):
921921
Returns:
922922
A `struct` representing a registry dependency.
923923
"""
924+
if not pin:
925+
return None
926+
924927
return struct(
925928
pin = pin,
926929
)

0 commit comments

Comments
 (0)