Extra Fields: #fix default value to be used for text type extra fields only when there is no value - refs BT#22502

NicoDucou · NicoDucou · commit 58f0faa4d89f · 2025-04-30T10:41:02.000+02:00
diff --git a/main/inc/lib/extra_field.lib.php b/main/inc/lib/extra_field.lib.php
@@ -1109,7 +1109,9 @@ public function set_extra_fields_in_form(
                         if (isset($field_details['default_value'])) {
                             $defaults['extra_'.$field_details['variable']] = $field_details['default_value'];
                         }
-                        $form->setDefaults($defaults);
+                        if (!isset($form->_defaultValues['extra_'.$field_details['variable']])) {
+                            $form->setDefaults($defaults);
+                        }
                         if ($freezeElement) {
                             $form->freeze('extra_'.$field_details['variable']);
                         }

Original file line number	Diff line number	Diff line change
`@@ -1109,7 +1109,9 @@ public function set_extra_fields_in_form(`
`1109`	`1109`	`if (isset($field_details['default_value'])) {`
`1110`	`1110`	`$defaults['extra_'.$field_details['variable']] = $field_details['default_value'];`
`1111`	`1111`	`}`
`1112`		`- $form->setDefaults($defaults);`
	`1112`	`+ if (!isset($form->_defaultValues['extra_'.$field_details['variable']])) {`
	`1113`	`+ $form->setDefaults($defaults);`
	`1114`	`+ }`
`1113`	`1115`	`if ($freezeElement) {`
`1114`	`1116`	`$form->freeze('extra_'.$field_details['variable']);`
`1115`	`1117`	`}`