Portfolio: Fix paths to handle video and audio tags when exporting to ZIP - refs BT#22709

Author: AngelFQC

main/inc/lib/PortfolioController.php

@@ -2351,7 +2351,7 @@ public function exportZip(HttpRequest $httpRequest)
 
             $itemFilename = sprintf('%s/items/%s/item.html', $tempPortfolioDirectory, $itemDirectory);
             $imagePaths = [];
-            $itemFileContent = $this->fixImagesSourcesToHtml($itemsHtml[$i], $imagePaths);
+            $itemFileContent = $this->fixMediaSourcesToHtml($itemsHtml[$i], $imagePaths);
 
             $fs->dumpFile($itemFilename, $itemFileContent);
 
@@ -2406,7 +2406,7 @@ public function exportZip(HttpRequest $httpRequest)
             $commentDirectory = $comment->getDate()->format('Y-m-d-H-i-s');
 
             $imagePaths = [];
-            $commentFileContent = $this->fixImagesSourcesToHtml($commentsHtml[$i], $imagePaths);
+            $commentFileContent = $this->fixMediaSourcesToHtml($commentsHtml[$i], $imagePaths);
             $commentFilename = sprintf('%s/comments/%s/comment.html', $tempPortfolioDirectory, $commentDirectory);
 
             $fs->dumpFile($commentFilename, $commentFileContent);
@@ -4292,21 +4292,44 @@ private function getCommentsInHtmlFormatted(array $comments): array
         return $commentsHtml;
     }
 
-    private function fixImagesSourcesToHtml(string $htmlContent, array &$imagePaths): string
+    /**
+     * @param string $htmlContent
+     * @param array $imagePaths Relative paths found in $htmlContent
+     *
+     * @return string
+     */
+    private function fixMediaSourcesToHtml(string $htmlContent, array &$imagePaths): string
     {
         $doc = new DOMDocument();
         @$doc->loadHTML($htmlContent);
 
-        $elements = $doc->getElementsByTagName('img');
+        $tagsWithSrc = ['img', 'video', 'audio', 'source'];
+        /** @var array<int, \DOMElement> $elements */
+        $elements = [];
+
+        foreach ($tagsWithSrc as $tag) {
+            foreach ($doc->getElementsByTagName($tag) as $element) {
+                if ($element->hasAttribute('src')) {
+                    $elements[] = $element;
+                }
+            }
+        }
 
-        if (empty($elements->length)) {
+        if (empty($elements)) {
             return $htmlContent;
         }
 
+        /** @var array<int, \DOMElement> $anchorElements */
+        $anchorElements = $doc->getElementsByTagName('a');
+
         $webPath = api_get_path(WEB_PATH);
         $sysPath = rtrim(api_get_path(SYS_PATH), '/');
 
-        /** @var \DOMElement $element */
+        $paths = [
+            '/app/upload/' => $sysPath,
+            '/courses/' => $sysPath.'/app'
+        ];
+
         foreach ($elements as $element) {
             $src = trim($element->getAttribute('src'));
 
@@ -4316,28 +4339,25 @@ private function fixImagesSourcesToHtml(string $htmlContent, array &$imagePaths)
                 continue;
             }
 
-            $src = str_replace($webPath, '/', $src);
-
-            if (strpos($src, '/app/upload/') === 0) {
-                $imagePaths[] = $sysPath.$src;
-
-                $element->setAttribute(
-                    'src',
-                    basename($src)
-                );
+            if ($anchorElements->length > 0) {
+                foreach ($anchorElements as $anchorElement) {
+                    if (!$anchorElement->hasAttribute('href')) {
+                        continue;
+                    }
 
-                continue;
+                    if ($src === $anchorElement->getAttribute('href')) {
+                        $anchorElement->setAttribute('href', basename($src));
+                    }
+                }
             }
 
-            if (strpos($src, '/courses/') === 0) {
-                $imagePaths[] = $sysPath.'/app'.$src;
-
-                $element->setAttribute(
-                    'src',
-                    basename($src)
-                );
+            $src = str_replace($webPath, '/', $src);
 
-                continue;
+            foreach ($paths as $prefix => $basePath) {
+                if (str_starts_with($src, $prefix)) {
+                    $imagePaths[] = $basePath.urldecode($src);
+                    $element->setAttribute('src', basename($src));
+                }
             }
         }