Internal: Revert PHP 8 compatibility improvement in api_htmlentities() as it causes issues filtering HTML tags in HTML titles - refs BT#22321

ywarnier · ywarnier · commit 8c16c19299b0 · 2024-12-24T12:12:50.000+01:00
diff --git a/main/inc/lib/internationalization.lib.php b/main/inc/lib/internationalization.lib.php
@@ -1207,7 +1207,7 @@ function api_htmlentities($string, $quote_style = ENT_COMPAT, $encoding = 'UTF-8
             break;
     }
 
-    return htmlspecialchars($string);
+    return mb_convert_encoding($string, 'HTML-ENTITIES', 'UTF-8');
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -1207,7 +1207,7 @@ function api_htmlentities($string, $quote_style = ENT_COMPAT, $encoding = 'UTF-8`
`1207`	`1207`	`break;`
`1208`	`1208`	`}`
`1209`	`1209`
`1210`		`- return htmlspecialchars($string);`
	`1210`	`+ return mb_convert_encoding($string, 'HTML-ENTITIES', 'UTF-8');`
`1211`	`1211`	`}`
`1212`	`1212`
`1213`	`1213`	`/**`