Extra Fields: #fix default value to be used for text type extra fields only when there is no value and it is not null - refs BT#22502

NicoDucou · NicoDucou · commit db1a302f90cd · 2025-05-08T09:04:27.000+02:00
diff --git a/main/inc/lib/extra_field.lib.php b/main/inc/lib/extra_field.lib.php
@@ -1106,7 +1106,7 @@ public function set_extra_fields_in_form(
                             'extra_'.$field_details['variable'],
                             'html_filter'
                         );
-                        if (isset($field_details['default_value'])) {
+                        if (!empty($field_details['default_value'])) {
                             $defaults['extra_'.$field_details['variable']] = $field_details['default_value'];
                         }
                         if (!isset($form->_defaultValues['extra_'.$field_details['variable']])) {

Original file line number	Diff line number	Diff line change
`@@ -1106,7 +1106,7 @@ public function set_extra_fields_in_form(`
`1106`	`1106`	`'extra_'.$field_details['variable'],`
`1107`	`1107`	`'html_filter'`
`1108`	`1108`	`);`
`1109`		`- if (isset($field_details['default_value'])) {`
	`1109`	`+ if (!empty($field_details['default_value'])) {`
`1110`	`1110`	`$defaults['extra_'.$field_details['variable']] = $field_details['default_value'];`
`1111`	`1111`	`}`
`1112`	`1112`	`if (!isset($form->_defaultValues['extra_'.$field_details['variable']])) {`