Skip to content

Commit 294e23d

Browse files
committed
docs: delete_chat(): Don't lie that messages aren't deleted from server
Messages are actually deleted from the server. I've checked this in Desktop.
1 parent 1847367 commit 294e23d

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

deltachat-ffi/deltachat.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1611,10 +1611,10 @@ void dc_set_chat_visibility (dc_context_t* context, uint32_t ch
16111611
*
16121612
* Messages are deleted from the device and the chat database entry is deleted.
16131613
* After that, the event #DC_EVENT_MSGS_CHANGED is posted.
1614+
* Messages are deleted from the server in background.
16141615
*
16151616
* Things that are _not_ done implicitly:
16161617
*
1617-
* - Messages are **not deleted from the server**.
16181618
* - The chat or the contact is **not blocked**, so new messages from the user/the group may appear
16191619
* and the user may create the chat again.
16201620
* - **Groups are not left** - this would

deltachat-jsonrpc/src/api.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -795,11 +795,11 @@ impl CommandApi {
795795
/// Delete a chat.
796796
///
797797
/// Messages are deleted from the device and the chat database entry is deleted.
798-
/// After that, the event #DC_EVENT_MSGS_CHANGED is posted.
798+
/// After that, a `MsgsChanged` event is emitted.
799+
/// Messages are deleted from the server in background.
799800
///
800801
/// Things that are _not done_ implicitly:
801802
///
802-
/// - Messages are **not deleted from the server**.
803803
/// - The chat or the contact is **not blocked**, so new messages from the user/the group may appear as a contact request
804804
/// and the user may create the chat again.
805805
/// - **Groups are not left** - this would

src/chat.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -600,6 +600,10 @@ impl ChatId {
600600
}
601601

602602
/// Deletes a chat.
603+
///
604+
/// Messages are deleted from the device and the chat database entry is deleted.
605+
/// After that, a `MsgsChanged` event is emitted.
606+
/// Messages are deleted from the server in background.
603607
pub async fn delete(self, context: &Context) -> Result<()> {
604608
self.delete_ex(context, Sync).await
605609
}

0 commit comments

Comments
 (0)