Skip to content

Commit e6977b3

Browse files
committed
undo sendall() change unrelated to the bug fix
1 parent add128a commit e6977b3

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

cheroot/ssl/pyopenssl.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -151,22 +151,20 @@ def readline(self, size=-1):
151151
)
152152

153153
def read(self, *args, **kwargs):
154-
"""Read from the wrapped socket, with retry."""
154+
"""Read from the wrapped socket."""
155155
return self._safe_call(
156156
True,
157157
super(SSLFileobjectMixin, self).read,
158158
*args, **kwargs
159159
)
160160

161161
def sendall(self, *args, **kwargs):
162-
"""Send whole message to the socket. Unsupported, do not use."""
163-
# Not supported due to https://github.com/pyca/pyopenssl/issues/176.
164-
# Until that bug is fixed, sendall() may throw SSL.WantWriteError, but
165-
# there is no correct way to retry the call because we don't know how
166-
# many bytes were already transmitted. We could work around this by
167-
# reimplementing sendall() using send(), but we don't actually use
168-
# sendall() anywhere.
169-
raise NotImplementedError('sendall() is unsupported by pyOpenSSL')
162+
"""Send whole message to the socket."""
163+
return self._safe_call(
164+
False,
165+
super(SSLFileobjectMixin, self).sendall,
166+
*args, **kwargs
167+
)
170168

171169
def send(self, *args, **kwargs):
172170
"""Send some part of message to the socket."""

0 commit comments

Comments
 (0)