Share button updates #2285
Open
Share button updates #2285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patphg
commented
Apr 23, 2024
patphg
commented
- Hides the share API button until support is detected instead of hiding after
- Changes FontAwesome CSS icon elements to HTML for SVG swapping
- Improvements to A11y of share buttons
- Adds X to the array of detected social names
* Hides the share API button until support is detected instead of hiding after * Changes FontAwesome CSS icon elements to HTML for SVG swapping * Improvements to A11y of share buttons * Adds X to the array of detected social names
chrisblakley
requested changes
Apr 23, 2024
assets/scss/partials/_helpers.scss
Outdated
| //Nebula social share buttons | ||
| a.nebula-share-btn {display: inline-block; padding: 5px 7px; border-radius: 3px; font-size: rem(12px); line-height: 1; color: #fff !important; text-shadow: 1px 1px rgb(0 0 0 / 25%); margin-right: 5px; | ||
| &:last-child {margin-right: 0;} | ||
| &::before {font-family: "Font Awesome 5 Brands"; margin-right: 4px; text-shadow: none;} |
Owner
There was a problem hiding this comment.
Without the encoded before content, the icons do not appear for me:
Compared to when I add them back (by reverting to previous):
| if ( in_array($network, array('facebook', 'fb')) ){ | ||
| echo '<a class="nebula-share-btn facebook" href="http://www.facebook.com/sharer.php?u=' . $encoded_url . '&t=' . $encoded_title . '" target="_blank" rel="noopener">' . __('Share', 'nebula') . '</a>'; | ||
| echo '<a class="nebula-share-btn facebook" href="http://www.facebook.com/sharer.php?u=' . $encoded_url . '&t=' . $encoded_title . '" target="_blank" rel="noopener" title="Share on Facebook"><i class="fa-brands fa-facebook me-1"></i>' . __('Share', 'nebula') . '</a>'; |
Owner
There was a problem hiding this comment.
Only note here is lets wrap the titles in translation functions so instead of:
title="Share on Facebook"
use:
title="' . __('Share on Facebook', 'nebula') . '"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.