Commit 647ccc5
committed
ios: Add privacy manifest, copying deps' reasons for "required reason APIs"
Apple has a new requirement to declare reasons for using certain
potentially privacy-sensitive APIs. It calls these "required reason
APIs":
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api?language=objc
Starting May 1, we risk being prevented from publishing until we
properly do that: zulip#5847.
We don't have much iOS code of our own, and none of it uses these
APIs (I've checked). But some of our dependencies do, and we have to
handle that.
Specifically, we expect to have to aggregate the declared reasons of
all our dependencies that use these APIs, and declare them ourself.
(That is, of dependencies that are statically linked -- which we
expect them to be, since we don't call `use_frameworks!` in our
Podfile.) The dependencies declare them with a "privacy manifest"
file, and the place we declare them is in a privacy manifest of our
own.
Below are the reasons we're copying over, noted with the
dependencies that declare them:
---- File timestamp APIs ----
(rn-fetch-blob uses some of these APIs, but that project hasn't yet
merged a privacy manifest. Currently the only reason code we haven't
declared in this category is DDA9.1, and I don't think that applies.
The Apple doc says, "Declare this reason to display file timestamps
to the person using the device," and we don't do that.)
C617.1: "Declare this reason to access the timestamps, size, or
other metadata of files inside the app container, app group
container, or the app’s CloudKit container."
@react-native-async-storage/async-storage (using the privacy
manifest from the later version we take in zulip#5856, which is not
yet merged as of writing)
@sentry/react-native
expo-application (using the privacy manifest added recently in
expo/expo@b8e40614b, which we haven't taken because Expo
upgrades take a lot of effort)
react-native (using the privacy manifest added very recently in
facebook/react-native@d39712f54, which we haven't taken because
RN upgrades take a lot of effort)
~~0A2A.1~~ We considered including this because of expo-file-system
but concluded that it's not appropriate for our privacy manifest;
details here:
zulip#5859 (comment)
3B52.1: "Declare this reason to access the timestamps, size, or
other metadata of files or directories that the user specifically
granted access to, such as using a document picker view
controller."
expo-file-system (using the privacy manifest added recently in
expo/expo@b8e40614b, which we haven't taken because Expo
upgrades take a lot of effort)
---- System boot time APIs ----
35F9.1: "Declare this reason to access the system boot time in order
to measure the amount of time that has elapsed between events that
occurred within the app or to perform calculations to enable
timers.
Information accessed for this reason, or any derived information,
may not be sent off-device. There is an exception for information
about the amount of time that has elapsed between events that
occurred within the app, which may be sent off-device."
@sentry/react-native
react-native (using the privacy manifest added very recently in
facebook/react-native@d39712f54, which we haven't taken because
RN upgrades take a lot of effort)
---- Disk space APIs ----
(rn-fetch-blob uses some of these APIs, but that project hasn't
merged a privacy manifest yet. Currently the only reasons we haven't
declared in this category are 7D9E.1 and B728.1, and I don't think
those apply.)
85F4.1: "Declare this reason to display disk space information to
the person using the device. Disk space may be displayed in units
of information (such as bytes) or units of time combined with a
media type (such as minutes of HD video).
Information accessed for this reason, or any derived information,
may not be sent off-device. There is an exception that allows the
app to send disk space information over the local network to
another device operated by the same person only for the purpose of
displaying disk space information on that device; this exception
only applies if the user has provided explicit permission to send
disk space information, and the information may not be sent over
the Internet."
expo-file-system (using the privacy manifest added recently in
expo/expo@b8e40614b, which we haven't taken because Expo
upgrades take a lot of effort)
E174.1: "Declare this reason to check whether there is sufficient
disk space to write files, or to check whether the disk space is
low so that the app can delete files when the disk space is low.
The app must behave differently based on disk space in a way that
is observable to users.
Information accessed for this reason, or any derived information,
may not be sent off-device. There is an exception that allows the
app to avoid downloading files from a server when disk space is
insufficient."
expo-file-system (using the privacy manifest added recently in
expo/expo@b8e40614b, which we haven't taken because Expo
upgrades take a lot of effort)
---- User defaults APIs ----
(expo-error-recovery uses some of these APIs, but that project
hasn't merged a privacy manifest yet, and we don't expect it to
because it is deprecated and not used in recent versions of Expo;
see expo/expo@87ffd749a. I don't *think* our app ends up using
expo-error-recovery; its README makes it sound like something we
would be aware of if it were active: "`expo-error-recovery` helps
you gracefully handle crashes caused by fatal JavaScript errors.".)
CA92.1: "Declare this reason to access user defaults to read and
write information that is only accessible to the app itself.
This reason does not permit reading information that was written
by other apps or the system, or writing information that can be
accessed by other apps."
@sentry/react-native
expo-constants (using the privacy manifest added recently in
expo/expo@b8e40614b, which we haven't taken because Expo
upgrades take a lot of effort)
expo-file-system (using the privacy manifest added recently in
expo/expo@b8e40614b, which we haven't taken because Expo
upgrades take a lot of effort)
react-native (using the privacy manifest added very recently in
facebook/react-native@d39712f54, which we haven't taken because
RN upgrades take a lot of effort)
Fixes: zulip#58471 parent ae4cf01 commit 647ccc5
File tree
2 files changed
+49
-0
lines changed- ios
- ZulipMobile.xcodeproj
2 files changed
+49
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
112 | 114 | | |
113 | 115 | | |
114 | 116 | | |
| 117 | + | |
115 | 118 | | |
116 | 119 | | |
117 | 120 | | |
| |||
238 | 241 | | |
239 | 242 | | |
240 | 243 | | |
| 244 | + | |
241 | 245 | | |
242 | 246 | | |
243 | 247 | | |
| |||
0 commit comments