Skip to content

Commit 3dfab84

Browse files
authored
[BUG]: Revert serde_bytes deserialize (#5501)
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Reverts #5396 - New functionality - ... ## Test plan _How are these changes tested?_ - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan None ## Observability plan lodc errors should go away in prod ## Documentation Changes None
1 parent 9116e7a commit 3dfab84

File tree

4 files changed

+2
-14
lines changed

4 files changed

+2
-14
lines changed

Cargo.lock

Lines changed: 0 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ sea-query = "0.32"
3737
sea-query-binder = "0.7"
3838
serde = { version = "1.0.215", features = ["derive", "rc"] }
3939
serde_json = "1.0.133"
40-
serde_bytes = "0.11.17"
4140
setsum = "0.7"
4241
sprs = "0.11"
4342
tantivy = "0.22.0"

rust/blockstore/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ path = "src/lib.rs"
88

99
[dependencies]
1010
serde = { workspace = true }
11-
serde_bytes = { workspace = true }
1211
arrow = { workspace = true }
1312
thiserror = { workspace = true }
1413
uuid = { workspace = true }

rust/blockstore/src/arrow/block/types.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ impl<'de> Deserialize<'de> for RecordBatchWrapper {
6868
where
6969
D: serde::Deserializer<'de>,
7070
{
71-
let data: &'de [u8] = serde_bytes::deserialize(deserializer)?;
72-
let rb = Block::load_record_batch(data, false).map_err(D::Error::custom)?;
71+
let data = Vec::<u8>::deserialize(deserializer)?;
72+
let rb = Block::load_record_batch(&data, false).map_err(D::Error::custom)?;
7373
Ok(RecordBatchWrapper(rb))
7474
}
7575
}

0 commit comments

Comments
 (0)