Skip to content

Conversation

@sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Sep 18, 2025

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

None

Observability plan

lodc errors should go away in prod

Documentation Changes

None

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia sanketkedia requested a review from HammadB September 18, 2025 00:23
@sanketkedia sanketkedia marked this pull request as ready for review September 18, 2025 00:23
@propel-code-bot
Copy link
Contributor

propel-code-bot bot commented Sep 18, 2025

Revert Usage of serde_bytes in Blockstore Deserialization

This pull request reverts the introduction of the serde_bytes crate for deserializing binary data within the RecordBatchWrapper of the blockstore. Instead of relying on serde_bytes, deserialization has been modified to use the default Vec<u8> deserialization. Associated references to the serde_bytes crate have been removed from Cargo.toml, the workspace manifest, and the blockstore's Cargo.toml, as well as from the Cargo.lock file.

Key Changes

• Replaced usage of serde_bytes::deserialize() with standard Vec<u8>::deserialize() in rust/blockstore/src/arrow/block/types.rs.
• Removed serde_bytes from dependencies in Cargo.toml, rust/blockstore/Cargo.toml, and Cargo.lock.
• Updated deserialization logic to maintain functionality without serde_bytes.

Affected Areas

rust/blockstore/src/arrow/block/types.rs
Cargo.toml
rust/blockstore/Cargo.toml
Cargo.lock

This summary was automatically generated by @propel-code-bot

@blacksmith-sh blacksmith-sh bot deleted a comment from sanketkedia Sep 18, 2025
@sanketkedia sanketkedia merged commit 3dfab84 into main Sep 18, 2025
114 of 116 checks passed
chroma-droid pushed a commit that referenced this pull request Sep 18, 2025
## Description of changes

_Summarize the changes made by this PR._

- Improvements & Bug fixes
  - Reverts #5396
- New functionality
  - ...

## Test plan

_How are these changes tested?_
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Migration plan
None

## Observability plan
lodc errors should go away in prod

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants