macos_session: add with_writer for macOS #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneychang
requested review from
bergwolf,
eryugey,
imeoer and
liubogithub
as code owners
sidneychang
force-pushed
the
add_with_writer
branch
from
c3d06f4 to
b8c69ff
Compare
macos_session originally lacked the `with_writer` API. This commit ports the implementation from `linux_session` to provide a consistent interface across platforms.
sidneychang
force-pushed
the
add_with_writer
branch
from
b8c69ff to
24585f0
Compare
Contributor
Author
Collaborator
|
Thanks, dup with #216 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macos_session originally lacked the
with_writerAPI. This commit ports the implementation fromlinux_sessionto provide a consistent interface across platforms.