Skip to content

Make NewSocks5Proxy hostKey parameter public as SSHHostKeyFetcher for extendability #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make NewSocks5Proxy hostKey parameter public as SSHHostKeyFetcher for extendability #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions socks5_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,28 @@ import (

var netListen = net.Listen

type hostKey interface {
// SSHHostKeyFetcher is the interface to get the SSH server jumphost public key
//
// The username is the login username to the SSH server
// The privateKey is the client login private SSH key (PEM-encoded)
// The serverURL is the IP/hostname and port of the SSH server.
// NOTE: The port must always be specified and port 22 is not implicitly assumed. E.g "jumphost:22"
type SSHHostKeyFetcher interface {
Get(username, privateKey, serverURL string) (ssh.PublicKey, error)
}

type DialFunc func(network, address string) (net.Conn, error)

type Socks5Proxy struct {
hostKey hostKey
hostKey SSHHostKeyFetcher
port int
started bool
keepAliveInterval time.Duration
logger *log.Logger
mtx sync.Mutex
}

func NewSocks5Proxy(hostKey hostKey, logger *log.Logger, keepAliveInterval time.Duration) *Socks5Proxy {
func NewSocks5Proxy(hostKey SSHHostKeyFetcher, logger *log.Logger, keepAliveInterval time.Duration) *Socks5Proxy {
return &Socks5Proxy{
hostKey: hostKey,
started: false,
Expand Down