Decode and document URL-encoded passwords

Author: clue

README.md

@@ -134,12 +134,13 @@ $factory->createClient('redis://localhost:6379');
 
 Redis supports password-based authentication (`AUTH` command). Note that Redis'
 authentication mechanism does not employ a username, so you can pass the
-password "secret" as part of the URI like this:
+password `h@llo` URL-encoded (percent-encoded) as part of the URI like this:
 
 ```php
-// both forms are equivalent
-$factory->createClient('redis://ignored:secret@localhost');
-$factory->createClient('redis://localhost?password=secret');
+// all forms are equivalent
+$factory->createClient('redis://:h%40llo@localhost');
+$factory->createClient('redis://ignored:h%40llo@localhost');
+$factory->createClient('redis://localhost?password=h%40llo');
 ```
 
 > Legacy notice: The `redis://` scheme is defined and preferred as of `v1.2.0`.

src/Factory.php

@@ -123,10 +123,10 @@ private function parseUrl($target)
 
         $auth = null;
         if (isset($parts['user']) && $parts['scheme'] === 'tcp') {
-            $auth = $parts['user'];
+            $auth = rawurldecode($parts['user']);
         }
         if (isset($parts['pass'])) {
-            $auth .= ($parts['scheme'] === 'tcp' ? ':' : '') . $parts['pass'];
+            $auth .= ($parts['scheme'] === 'tcp' ? ':' : '') . rawurldecode($parts['pass']);
         }
         if ($auth !== null) {
             $parts['auth'] = $auth;

tests/FactoryTest.php

@@ -86,6 +86,15 @@ public function testWillWriteAuthCommandIfRedisUriContainsUserInfo()
         $this->factory->createClient('redis://hello:[email protected]');
     }
 
+    public function testWillWriteAuthCommandIfRedisUriContainsEncodedUserInfo()
+    {
+        $stream = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();
+        $stream->expects($this->once())->method('write')->with("*2\r\n$4\r\nauth\r\n$5\r\nh@llo\r\n");
+
+        $this->connector->expects($this->once())->method('connect')->with('example.com:6379')->willReturn(Promise\resolve($stream));
+        $this->factory->createClient('redis://:h%[email protected]');
+    }
+
     public function testWillWriteAuthCommandIfTargetContainsPasswordQueryParameter()
     {
         $stream = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();
@@ -95,6 +104,15 @@ public function testWillWriteAuthCommandIfTargetContainsPasswordQueryParameter()
         $this->factory->createClient('redis://example.com?password=secret');
     }
 
+    public function testWillWriteAuthCommandIfTargetContainsEncodedPasswordQueryParameter()
+    {
+        $stream = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();
+        $stream->expects($this->once())->method('write')->with("*2\r\n$4\r\nauth\r\n$5\r\nh@llo\r\n");
+
+        $this->connector->expects($this->once())->method('connect')->with('example.com:6379')->willReturn(Promise\resolve($stream));
+        $this->factory->createClient('redis://example.com?password=h%40llo');
+    }
+
     public function testWillWriteAuthCommandIfRedissUriContainsUserInfo()
     {
         $stream = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();