Add object-shorthand and no-useless-rename rules to default config

matejchalk · matejchalk · commit 47cfc7886797 · 2024-10-03T16:20:38.000+02:00
closes #19
diff --git a/docs/angular-ngrx.md b/docs/angular-ngrx.md
@@ -47,9 +47,9 @@ Config for **Angular** projects using **NgRx** library.
    }
    ```
 
-## 📏 Rules (370)
+## 📏 Rules (372)
 
-**340** rules are included from [`@code-pushup/eslint-config/angular`](./angular.md#📏-rules-340). For brevity, only the **30** additional rules are listed in this document.
+**342** rules are included from [`@code-pushup/eslint-config/angular`](./angular.md#📏-rules-342). For brevity, only the **30** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/docs/angular.md b/docs/angular.md
@@ -47,9 +47,9 @@ Config for **Angular** projects.
    }
    ```
 
-## 📏 Rules (370)
+## 📏 Rules (372)
 
-**295** rules are included from [`@code-pushup/eslint-config/typescript`](./typescript.md#📏-rules-295). For brevity, only the **75** additional rules are listed in this document.
+**297** rules are included from [`@code-pushup/eslint-config/typescript`](./typescript.md#📏-rules-297). For brevity, only the **75** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/docs/graphql.md b/docs/graphql.md
@@ -33,9 +33,9 @@ Config for **GraphQL servers** implemented in Node.js.
    }
    ```
 
-## 📏 Rules (292)
+## 📏 Rules (294)
 
-**265** rules are included from [`@code-pushup/eslint-config/node`](./node.md#📏-rules-265). For brevity, only the **27** additional rules are listed in this document.
+**267** rules are included from [`@code-pushup/eslint-config/node`](./node.md#📏-rules-267). For brevity, only the **27** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/docs/index.md b/docs/index.md
@@ -6,7 +6,7 @@ Default config, suitable for any **JavaScript/TypeScript** project.
 
 Refer to [setup instructions in README](../README.md#🏗️-setup).
 
-## 📏 Rules (249)
+## 📏 Rules (251)
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
@@ -129,7 +129,7 @@ Refer to [setup instructions in README](../README.md#🏗️-setup).
 |     [![sonarjs](./icons/other/sonar.png)](https://github.com/SonarSource/eslint-plugin-sonarjs#readme)     | [prefer-single-boolean-return](https://github.com/SonarSource/eslint-plugin-sonarjs/blob/master/docs/rules/prefer-single-boolean-return.md)<br />Return of boolean expressions should not be wrapped into an "if-then-else" statement |                                                                                                                                                                                                                                 |   💡    |           |
 |     [![sonarjs](./icons/other/sonar.png)](https://github.com/SonarSource/eslint-plugin-sonarjs#readme)     | [prefer-while](https://github.com/SonarSource/eslint-plugin-sonarjs/blob/master/docs/rules/prefer-while.md)<br />A "while" loop should be used instead of a "for" loop                                                                |                                                                                                                                                                                                                                 |   🔧    |           |
 
-### ⚠️ Warnings (135)
+### ⚠️ Warnings (137)
 
 |                                                      Plugin                                                      | Rule                                                                                                                                                                                                                                                                                                                                                     | Options                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     | Autofix | Overrides |
 | :--------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :-----: | :-------: |
@@ -144,6 +144,8 @@ Refer to [setup instructions in README](../README.md#🏗️-setup).
 |                                                                                                                  | [no-console](https://eslint.org/docs/latest/rules/no-console)<br />Disallow the use of `console`                                                                                                                                                                                                                                                         | <details><summary>allow: error, warn, info</summary><pre lang="json"><code>{&#13;  "allow": [&#13;    "error",&#13;    "warn",&#13;    "info"&#13;  ]&#13;}</code></pre></details>                                                                                                                                                                                                                                                                                                                                                                                                                          |   💡    |           |
 |                                                                                                                  | [no-duplicate-imports](https://eslint.org/docs/latest/rules/no-duplicate-imports)<br />Disallow duplicate module imports                                                                                                                                                                                                                                 |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |         |           |
 |                                                                                                                  | [no-undef-init](https://eslint.org/docs/latest/rules/no-undef-init)<br />Disallow initializing variables to `undefined`                                                                                                                                                                                                                                  |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |   🔧    |           |
+|                                                                                                                  | [no-useless-rename](https://eslint.org/docs/latest/rules/no-useless-rename)<br />Disallow renaming import, export, and destructured assignments to the same name                                                                                                                                                                                         |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |   🔧    |           |
+|                                                                                                                  | [object-shorthand](https://eslint.org/docs/latest/rules/object-shorthand)<br />Require or disallow method and property shorthand syntax for object literals                                                                                                                                                                                              |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |   🔧    |           |
 |                                                                                                                  | [prefer-template](https://eslint.org/docs/latest/rules/prefer-template)<br />Require template literals instead of string concatenation                                                                                                                                                                                                                   |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |   🔧    |           |
 |                                                                                                                  | [radix](https://eslint.org/docs/latest/rules/radix)<br />Enforce the consistent use of the radix argument when using `parseInt()`                                                                                                                                                                                                                        |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |   💡    |           |
 |                                                                                                                  | [yoda](https://eslint.org/docs/latest/rules/yoda)<br />Require or disallow "Yoda" conditions                                                                                                                                                                                                                                                             |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |   🔧    |           |
diff --git a/docs/node.md b/docs/node.md
@@ -19,9 +19,9 @@ Config for **Node.js** projects.
    }
    ```
 
-## 📏 Rules (253)
+## 📏 Rules (255)
 
-**249** rules are included from [the default config](./index.md#📏-rules-249). For brevity, only the **4** additional rules are listed in this document.
+**251** rules are included from [the default config](./index.md#📏-rules-251). For brevity, only the **4** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/docs/typescript.md b/docs/typescript.md
@@ -64,9 +64,9 @@ Config for strict **TypeScript** projects.
    }
    ```
 
-## 📏 Rules (296)
+## 📏 Rules (298)
 
-**249** rules are included from [the default config](./index.md#📏-rules-249). For brevity, only the **47** additional rules are listed in this document.
+**251** rules are included from [the default config](./index.md#📏-rules-251). For brevity, only the **47** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/index.js b/index.js
@@ -93,6 +93,7 @@ module.exports = {
       { skipBlankLines: true, skipComments: true },
     ],
     'max-nested-callbacks': ['warn', { max: 3 }],
+    'object-shorthand': 'warn',
     'no-bitwise': 'warn',
     'no-console': ['warn', { allow: ['error', 'warn', 'info'] }],
     'no-duplicate-imports': 'warn',
@@ -102,6 +103,7 @@ module.exports = {
     'no-template-curly-in-string': 'error',
     'no-undef-init': 'warn',
     'no-unreachable-loop': 'error',
+    'no-useless-rename': 'warn',
     'prefer-template': 'warn',
     radix: 'warn',
     yoda: 'warn',

Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,9 @@ Config for Angular projects using NgRx library.`
`47`	`47`	`}`
`48`	`48`	```
`49`	`49`
`50`		`-## 📏 Rules (370)`
	`50`	`+## 📏 Rules (372)`
`51`	`51`
`52`		-340 rules are included from [`@code-pushup/eslint-config/angular`](./angular.md#📏-rules-340). For brevity, only the 30 additional rules are listed in this document.
	`52`	+342 rules are included from [`@code-pushup/eslint-config/angular`](./angular.md#📏-rules-342). For brevity, only the 30 additional rules are listed in this document.
`53`	`53`
`54`	`54`	> 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
`55`	`55`
Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,9 @@ Config for GraphQL servers implemented in Node.js.`
`33`	`33`	`}`
`34`	`34`	```
`35`	`35`
`36`		`-## 📏 Rules (292)`
	`36`	`+## 📏 Rules (294)`
`37`	`37`
`38`		-265 rules are included from [`@code-pushup/eslint-config/node`](./node.md#📏-rules-265). For brevity, only the 27 additional rules are listed in this document.
	`38`	+267 rules are included from [`@code-pushup/eslint-config/node`](./node.md#📏-rules-267). For brevity, only the 27 additional rules are listed in this document.
`39`	`39`
`40`	`40`	> 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,9 @@ Config for Node.js projects.`
`19`	`19`	`}`
`20`	`20`	```
`21`	`21`
`22`		`-## 📏 Rules (253)`
	`22`	`+## 📏 Rules (255)`
`23`	`23`
`24`		`-249 rules are included from [the default config](./index.md#📏-rules-249). For brevity, only the 4 additional rules are listed in this document.`
	`24`	`+251 rules are included from [the default config](./index.md#📏-rules-251). For brevity, only the 4 additional rules are listed in this document.`
`25`	`25`
`26`	`26`	> 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
`27`	`27`
Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,9 @@ Config for strict TypeScript projects.`
`64`	`64`	`}`
`65`	`65`	```
`66`	`66`
`67`		`-## 📏 Rules (296)`
	`67`	`+## 📏 Rules (298)`
`68`	`68`
`69`		`-249 rules are included from [the default config](./index.md#📏-rules-249). For brevity, only the 47 additional rules are listed in this document.`
	`69`	`+251 rules are included from [the default config](./index.md#📏-rules-251). For brevity, only the 47 additional rules are listed in this document.`
`70`	`70`
`71`	`71`	> 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
`72`	`72`