chore: remove code around URL building

It is already supported by java.net.URI

Author: fioan89

src/main/kotlin/com/coder/toolbox/cli/downloader/CoderDownloadService.kt

@@ -7,7 +7,6 @@ import com.coder.toolbox.util.SemVer
 import com.coder.toolbox.util.getHeaders
 import com.coder.toolbox.util.getOS
 import com.coder.toolbox.util.sha1
-import com.coder.toolbox.util.withLastSegment
 import okhttp3.ResponseBody
 import retrofit2.Response
 import java.io.FileInputStream
@@ -154,7 +153,7 @@ class CoderDownloadService(
     }
 
     private suspend fun downloadSignature(url: URL, showTextProgress: (String) -> Unit): DownloadResult {
-        val signatureURL = url.withLastSegment(context.settingsStore.defaultSignatureNameByOsAndArch)
+        val signatureURL = url.toURI().resolve(context.settingsStore.defaultSignatureNameByOsAndArch).toURL()
         val localSignaturePath = localBinaryPath.parent.resolve(context.settingsStore.defaultSignatureNameByOsAndArch)
         context.logger.info("Downloading signature from $signatureURL")
 

src/main/kotlin/com/coder/toolbox/util/URLExtensions.kt

@@ -13,20 +13,6 @@ fun URL.withPath(path: String): URL = URL(
     if (path.startsWith("/")) path else "/$path",
 )
 
-fun URL.withLastSegment(segment: String): URL {
-    val uri = this.toURI()
-    val basePath = uri.path.substringBeforeLast('/')
-    val newPath = "$basePath/$segment"
-    val newUri = URI(
-        uri.scheme,
-        uri.authority,
-        newPath,
-        uri.query,
-        uri.fragment
-    )
-    return newUri.toURL()
-}
-
 /**
  * Return the host, converting IDN to ASCII in case the file system cannot
  * support the necessary character set.