Skip to content

Commit feb15d4

Browse files
committed
rely on envs to fix app changes
1 parent d99cfa7 commit feb15d4

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

src/code-server/devcontainer-feature.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,11 @@
162162
{
163163
"slug": "code-server",
164164
"displayName": "code-server",
165-
"url": "http://${containerEnv:CODE_SERVER_HOST}:${containerEnv:CODE_SERVER_PORT}/${containerEnv:CODE_SERVER_FOLDER}",
165+
"url": "http://${localEnv:FEATURE_CODE_SERVER_HOST:127.0.0.1}:${localEnv:FEATURE_CODE_SERVER_PORT:8080}/",
166166
"openIn": "tab",
167167
"share": "owner",
168-
"icon": "/icons/web.svg",
169-
"order": 1,
170-
"group": "Web Editors"
168+
"icon": "/icon/code.svg",
169+
"group": "${localEnv:FEATURE_CODE_SERVER_APP_GROUP:Web Editors}"
171170
}
172171
]
173172
}

src/code-server/install.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ if [[ -n $WORKSPACE ]]; then
2222
CODE_SERVER_WORKSPACE="$WORKSPACE"
2323
fi
2424

25-
# Serialize these options in the container environment for reference in JSON.
26-
cat <<EOF >> /etc/environment
27-
CODE_SERVER_HOST=$HOST
28-
CODE_SERVER_PORT=$PORT
29-
CODE_SERVER_FOLDER=?folder=$CODE_SERVER_WORKSPACE
30-
EOF
31-
3225
FLAGS=()
3326
FLAGS+=(--auth "$AUTH")
3427
FLAGS+=(--bind-addr "$HOST:$PORT")

0 commit comments

Comments
 (0)