Update RDP module icons and Terraform provider version

- Replace desktop.svg with rdp.svg in RDP modules for consistency
- Update Coder provider version to 2.5 in windows-rdp module
- Simplify code by removing unused resource_id variable
- Correct URL in RDP documentation resource link

Author: matifali

registry/coder/modules/local-windows-rdp/README.md

@@ -12,8 +12,7 @@ tags: [rdp, windows, desktop, local]
 
 This module enables Remote Desktop Protocol (RDP) on Windows workspaces and adds a one-click button to launch RDP sessions directly through [Coder Desktop](https://coder.com/docs/user-guides/desktop). It provides a complete, standalone solution for RDP access, eliminating the need for manual configuration or port forwarding through the Coder CLI.
 
-> [!NOTE]
-> [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature.
+> [!NOTE] > [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature.
 
 ```tf
 module "rdp_desktop" {

registry/coder/modules/local-windows-rdp/main.tf

@@ -60,7 +60,7 @@ data "coder_workspace" "me" {}
 resource "coder_script" "rdp_setup" {
   agent_id     = var.agent_id
   display_name = "Configure RDP"
-  icon         = "/icon/desktop.svg"
+  icon         = "/icon/rdp.svg"
   script = templatefile("${path.module}/configure-rdp.ps1", {
     username = var.username
     password = var.password
@@ -73,9 +73,8 @@ resource "coder_app" "rdp_desktop" {
   slug         = "rdp-desktop"
   display_name = var.display_name
   url          = "coder://${local.server_name}/v0/open/ws/${data.coder_workspace.me.name}/agent/${var.agent_name}/rdp?username=${var.username}&password=${var.password}"
-  icon         = "/icon/desktop.svg"
+  icon         = "/icon/rdp.svg"
   external     = true
   order        = var.order
   group        = var.group
 }
-

registry/coder/modules/windows-rdp/main.tf

@@ -4,7 +4,7 @@ terraform {
   required_providers {
     coder = {
       source  = "coder/coder"
-      version = ">= 0.17"
+      version = ">= 2.5"
     }
   }
 }
@@ -35,11 +35,6 @@ variable "agent_id" {
   description = "The ID of a Coder agent."
 }
 
-variable "resource_id" {
-  type        = string
-  description = "The ID of the primary Coder resource (e.g. VM)."
-}
-
 variable "admin_username" {
   type    = string
   default = "Administrator"
@@ -60,7 +55,7 @@ variable "devolutions_gateway_version" {
 resource "coder_script" "windows-rdp" {
   agent_id     = var.agent_id
   display_name = "windows-rdp"
-  icon         = "/icon/desktop.svg"
+  icon         = "/icon/rdp.svg"
 
   script = templatefile("${path.module}/powershell-installation-script.tftpl", {
     admin_username              = var.admin_username
@@ -101,7 +96,7 @@ resource "coder_app" "rdp-docs" {
   agent_id     = var.agent_id
   display_name = "Local RDP Docs"
   slug         = "rdp-docs"
-  icon         = "https://raw.githubusercontent.com/matifali/logos/main/windows.svg"
-  url          = "https://coder.com/docs/ides/remote-desktops#rdp-desktop"
+  icon         = "/icon/windows.svg"
+  url          = "https://coder.com/docs/user-guides/workspace-access/remote-desktops#rdp"
   external     = true
 }