feat: Enhance health check API for improved security and clarity

- Remove sensitive information from health check responses: The API
  now avoids exposing database connection details, Redis host/port,
  Celery broker URL, and email server credentials to enhance
  security.  This prevents potential vulnerabilities.
- Improve the structure and readability of health check responses: The
  responses are now more concise and informative, providing clear
  status messages and relevant details about each service without
  compromising security.  This enhances the usability of the API.

Author: Mahmoud-Emad

server/views.py

@@ -57,14 +57,16 @@ def _check_database(self):
         try:
             # Try to connect to the database
             connections['default'].ensure_connection()
-            # Get database info
+            # Get database info (only non-sensitive information)
             db_info = {
                 "engine": settings.DATABASES['default']['ENGINE'].split('.')[-1],
-                "name": str(settings.DATABASES['default']['NAME'])  # Convert PosixPath to string
             }
-            if 'postgresql' in settings.DATABASES['default']['ENGINE']:
-                db_info["host"] = settings.DATABASES['default']['HOST']
-                db_info["port"] = settings.DATABASES['default']['PORT']
+            
+            # For security, we don't expose the full database path or connection details
+            if 'sqlite3' in settings.DATABASES['default']['ENGINE']:
+                db_info["type"] = "SQLite"
+            elif 'postgresql' in settings.DATABASES['default']['ENGINE']:
+                db_info["type"] = "PostgreSQL"
 
             return {
                 "status": True,
@@ -89,19 +91,23 @@ def _check_redis(self):
             r = redis.Redis(host=host, port=port, socket_connect_timeout=2)
             r.ping()
 
+            # For security, we don't expose the actual host and port
             return {
                 "status": True,
                 "message": "Redis connection successful",
                 "info": {
-                    "host": host,
-                    "port": port
+                    "service": "Redis",
+                    "connected": True
                 }
             }
         except Exception as e:
             return {
                 "status": False,
                 "message": f"Redis connection failed: {str(e)}",
-                "info": {}
+                "info": {
+                    "service": "Redis",
+                    "connected": False
+                }
             }
 
     def _check_celery(self):
@@ -114,26 +120,26 @@ def _check_celery(self):
 
             if stats:
                 # If we get stats, Celery is running
-                worker_names = list(stats.keys())
+                worker_count = len(stats.keys())
                 return {
                     "status": True,
                     "message": "Celery workers are running",
                     "info": {
-                        "workers": worker_names,
-                        "broker": celery_app.conf.broker_url
+                        "worker_count": worker_count,
+                        "service": "Celery"
                     }
                 }
             else:
                 # Try an alternative approach - check scheduled tasks
                 scheduled = inspector.scheduled()
                 if scheduled:
-                    worker_names = list(scheduled.keys())
+                    worker_count = len(scheduled.keys())
                     return {
                         "status": True,
                         "message": "Celery workers are running",
                         "info": {
-                            "workers": worker_names,
-                            "broker": celery_app.conf.broker_url
+                            "worker_count": worker_count,
+                            "service": "Celery"
                         }
                     }
 
@@ -142,7 +148,7 @@ def _check_celery(self):
                     "status": False,
                     "message": "No Celery workers are running",
                     "info": {
-                        "broker": celery_app.conf.broker_url
+                        "service": "Celery"
                     }
                 }
         except Exception as e:
@@ -152,8 +158,8 @@ def _check_celery(self):
                 "status": True,
                 "message": "Celery appears to be running, but connection check failed",
                 "info": {
-                    "broker": celery_app.conf.broker_url if hasattr(celery_app.conf, 'broker_url') else "unknown",
-                    "error": str(e)
+                    "service": "Celery",
+                    "error_type": type(e).__name__
                 }
             }
 
@@ -171,25 +177,29 @@ def _check_email(self):
                     "status": False,
                     "message": "Email service is not fully configured",
                     "info": {
-                        "host": settings.EMAIL_HOST,
-                        "port": settings.EMAIL_PORT
+                        "service": "Email",
+                        "configured": False
                     }
                 }
 
             # We don't actually connect to the SMTP server to avoid potential issues
             # Just check if the configuration exists
+            # For security, we don't expose the actual email credentials
             return {
                 "status": True,
                 "message": "Email service is configured",
                 "info": {
-                    "host": settings.EMAIL_HOST,
-                    "port": settings.EMAIL_PORT,
-                    "user": settings.EMAIL_HOST_USER
+                    "service": "Email",
+                    "configured": True,
+                    "provider": settings.EMAIL_HOST.split('.')[0] if '.' in settings.EMAIL_HOST else settings.EMAIL_HOST
                 }
             }
         except Exception as e:
             return {
                 "status": False,
                 "message": f"Email service check failed: {str(e)}",
-                "info": {}
+                "info": {
+                    "service": "Email",
+                    "configured": False
+                }
             }