Do not retry processing when there is no picture

Author: amureki

pictures/tasks.py

@@ -40,18 +40,22 @@ def process_picture_async(
     field = model._meta.get_field(field_name)
     storage = construct_storage(*storage_construct)
 
-    with storage.open(file_name) as file:
-        with Image.open(file) as img:
-            for ratio, sources in PictureFieldFile.get_picture_files(
-                file_name=file_name,
-                img_width=img.width,
-                img_height=img.height,
-                storage=storage,
-                field=field,
-            ).items():
-                for file_type, srcset in sources.items():
-                    for width, picture in srcset.items():
-                        picture.save(img)
+    try:
+        with storage.open(file_name) as file:
+            with Image.open(file) as img:
+                for ratio, sources in PictureFieldFile.get_picture_files(
+                    file_name=file_name,
+                    img_width=img.width,
+                    img_height=img.height,
+                    storage=storage,
+                    field=field,
+                ).items():
+                    for file_type, srcset in sources.items():
+                        for width, picture in srcset.items():
+                            picture.save(img)
+    except FileNotFoundError:
+        # The file no longer exists (for example, because it was deleted or replaced).
+        return
 
 
 try:

tests/test_tasks.py

@@ -16,3 +16,17 @@ def test_process_picture__file_cannot_be_reopened(image_upload_file):
         Mock(side_effect=ValueError("The file cannot be reopened.")),
     )
     tasks._process_picture(obj.picture)
+
+
+@pytest.mark.django_db
+def test_process_picture__file_missing(image_upload_file):
+    # Simulate the case where the file has been removed (or never existed)
+    # by making file.open raise FileNotFoundError.
+    obj = SimpleModel.objects.create(picture=image_upload_file)
+    setattr(
+        obj.picture.file,
+        "open",
+        Mock(side_effect=FileNotFoundError("File does not exist: test.jpg")),
+    )
+    # _process_picture should catch the FileNotFoundError and exit gracefully.
+    tasks._process_picture(obj.picture)