Fix #81 -- Finish machine tasks (#83)

Author: amureki

joeflow/tasks/machine.py

@@ -3,6 +3,8 @@
 
 from django.utils import timezone
 
+from ..typing import MACHINE
+
 __all__ = (
     "Start",
     "Join",
@@ -51,7 +53,8 @@ def end(self):
 
     def __call__(self, **kwargs):
         workflow = self.workflow_cls.objects.create(**kwargs)
-        task = workflow.task_set.create(name=self.name, workflow=workflow)
+        task = workflow.task_set.create(name=self.name, type=MACHINE, workflow=workflow)
+        task.finish()
         task.start_next_tasks()
         return workflow
 

tests/fixtures/simpleworkflow_instance.dot

@@ -3,7 +3,7 @@ digraph {
 	node [fillcolor=white fontname="sans-serif" shape=rect style=filled]
 	end [color="#888888" fontcolor="#888888" style=filled]
 	"save the princess" [color=black fontcolor=black href="/simple/save_the_princess/2/" peripheries=1 style="filled, rounded, bold"]
-	"start method" [color=black fontcolor=black peripheries=1 style="filled, bold"]
+	"start method" [color=black fontcolor=black peripheries=1 style=filled]
 	"start view" [color="#888888" fontcolor="#888888" style="filled, rounded"]
 	"save the princess" -> end [color="#888888"]
 	"start method" -> "save the princess" [color=black]

tests/tasks/test_machine.py

@@ -12,6 +12,10 @@ def test_call(self, db):
         wf = workflows.SimpleWorkflow.start_method(pk=3)
         assert wf.pk == 3
 
+        start_task = wf.task_set.get(name="start_method")
+        assert start_task.type == "machine"
+        assert start_task.status == "succeeded"
+
 
 class TestJoin:
     def test_init(self):

tests/test_views.py

@@ -22,11 +22,15 @@ def test_create_task(self, db, admin_client, admin_user):
         assert response.status_code == 302
 
         wf = workflows.SimpleWorkflow.objects.get()
-
         assert wf.task_set.count() == 2
+
+        start_task = wf.task_set.get(name="start_view")
+        assert start_task.type == "human"
+        assert start_task.status == "succeeded"
+
         new_task = wf.task_set.get(name="save_the_princess")
-        assert new_task.name == "save_the_princess"
         assert new_task.type == "human"
+        assert new_task.status == "scheduled"
         assert not new_task.assignees.all()
 
     def test_custom_create_task(self, db, admin_client, admin_user):
@@ -35,7 +39,7 @@ def test_custom_create_task(self, db, admin_client, admin_user):
         assert response.status_code == 302
 
         wf = workflows.AssigneeWorkflow.objects.get()
-
         assert wf.task_set.count() == 2
+
         new_task = wf.task_set.get(name="save_the_princess")
         assert admin_user in new_task.assignees.all()