Skip to content

Conversation

@dkuku
Copy link
Contributor

@dkuku dkuku commented Aug 12, 2025

πŸ›‘ New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.


✍️ Description

Adds Livebook

πŸ”— Related PR / Issue

Link: #788

βœ… Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

πŸ› οΈ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • πŸ’₯ Breaking change – Alters existing functionality in a way that may require updates.
  • πŸ†• New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • πŸ”§ Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • πŸ“ Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

πŸ” Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

πŸ“‹ Additional Information (optional)

@dkuku dkuku force-pushed the livebook branch 4 times, most recently from 64b466d to 28d4546 Compare August 13, 2025 17:49
@dkuku dkuku marked this pull request as ready for review August 13, 2025 18:14
@dkuku dkuku requested review from a team as code owners August 13, 2025 18:14
export HOME=/opt
touch $HOME/.env
cd /opt || exit 1
curl -fsSO https://elixir-lang.org/install.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Livebook requires minimum elixir 1.18 - it is not provided in any of the distro packages and I could not find any ppa for it - checked erlang solutions and the rabbit mq that is reccomended on
https://elixir-lang.org/install.html#distributions

I found this is the easiest way to install a recent version.
The official elixir docker images use similar logic.

Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check other Scripts. Many minor Issues Like /dev/null, static Versions,...

touch $HOME/.env
cd /opt || exit 1
curl -fsSO https://elixir-lang.org/install.sh
sh install.sh [email protected] [email protected] >/dev/null 2>&1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static Versionno. = No

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted it to variables
just like in adventurelog or hortusfox

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkuku PHP and Python are much wider spread and that's something we can easier keep track of, also these were only major and minor version, you seem to also include patch version.

can you make some sort of fetch like in homarr for example?

https://github.com/community-scripts/ProxmoxVE/blob/main/ct/homarr.sh#L102-L103


msg_info "Installing Livebook"
RELEASE=$(curl -fsSL https://api.github.com/repos/livebook-dev/livebook/releases/latest | grep "tag_name" | awk -F'"' '{print $4}')
echo "${RELEASE}" >/opt/Livebook_version.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this suppose to work? Is it only set after the first update ?

@dkuku dkuku marked this pull request as draft August 13, 2025 20:03
touch $HOME/.env
cd /opt || exit 1
curl -fsSO https://elixir-lang.org/install.sh
sh install.sh [email protected] [email protected] >/dev/null 2>&1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkuku PHP and Python are much wider spread and that's something we can easier keep track of, also these were only major and minor version, you seem to also include patch version.

can you make some sort of fetch like in homarr for example?

https://github.com/community-scripts/ProxmoxVE/blob/main/ct/homarr.sh#L102-L103

@dkuku dkuku force-pushed the livebook branch 2 times, most recently from 688453d to 34d82e1 Compare August 17, 2025 08:40
@dkuku dkuku marked this pull request as ready for review August 17, 2025 09:23
@dkuku dkuku marked this pull request as draft August 17, 2025 18:17
@dkuku
Copy link
Contributor Author

dkuku commented Aug 17, 2025

I updated the files but currently my proxmox installation makes problems (I'm running it in temporary from qemu and it has problems to connect to network)

@dkuku
Copy link
Contributor Author

dkuku commented Aug 31, 2025

@MickLesk I tested it and it works ok.

@dkuku dkuku marked this pull request as ready for review August 31, 2025 17:30
@dkuku dkuku force-pushed the livebook branch 3 times, most recently from 13b3434 to 3f5166e Compare September 7, 2025 13:02
@dkuku dkuku requested a review from CrazyWolf13 September 7, 2025 13:15
@MickLesk MickLesk merged commit 94c288b into community-scripts:main Sep 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants