-
-
Notifications
You must be signed in to change notification settings - Fork 148
Livebook #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Livebook #796
Conversation
64b466d to
28d4546
Compare
| export HOME=/opt | ||
| touch $HOME/.env | ||
| cd /opt || exit 1 | ||
| curl -fsSO https://elixir-lang.org/install.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Livebook requires minimum elixir 1.18 - it is not provided in any of the distro packages and I could not find any ppa for it - checked erlang solutions and the rabbit mq that is reccomended on
https://elixir-lang.org/install.html#distributions
I found this is the easiest way to install a recent version.
The official elixir docker images use similar logic.
MickLesk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check other Scripts. Many minor Issues Like /dev/null, static Versions,...
install/livebook-install.sh
Outdated
| touch $HOME/.env | ||
| cd /opt || exit 1 | ||
| curl -fsSO https://elixir-lang.org/install.sh | ||
| sh install.sh [email protected] [email protected] >/dev/null 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static Versionno. = No
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extracted it to variables
just like in adventurelog or hortusfox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkuku PHP and Python are much wider spread and that's something we can easier keep track of, also these were only major and minor version, you seem to also include patch version.
can you make some sort of fetch like in homarr for example?
https://github.com/community-scripts/ProxmoxVE/blob/main/ct/homarr.sh#L102-L103
install/livebook-install.sh
Outdated
|
|
||
| msg_info "Installing Livebook" | ||
| RELEASE=$(curl -fsSL https://api.github.com/repos/livebook-dev/livebook/releases/latest | grep "tag_name" | awk -F'"' '{print $4}') | ||
| echo "${RELEASE}" >/opt/Livebook_version.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this suppose to work? Is it only set after the first update ?
install/livebook-install.sh
Outdated
| touch $HOME/.env | ||
| cd /opt || exit 1 | ||
| curl -fsSO https://elixir-lang.org/install.sh | ||
| sh install.sh [email protected] [email protected] >/dev/null 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkuku PHP and Python are much wider spread and that's something we can easier keep track of, also these were only major and minor version, you seem to also include patch version.
can you make some sort of fetch like in homarr for example?
https://github.com/community-scripts/ProxmoxVE/blob/main/ct/homarr.sh#L102-L103
0755572 to
c7c5fa5
Compare
688453d to
34d82e1
Compare
|
I updated the files but currently my proxmox installation makes problems (I'm running it in temporary from qemu and it has problems to connect to network) |
|
@MickLesk I tested it and it works ok. |
13b3434 to
3f5166e
Compare
π New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.
βοΈ Description
Adds Livebook
π Related PR / Issue
Link: #788
β Prerequisites (X in brackets)
π οΈ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.π Code & Security Review (X in brackets)
Code_Audit.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)π Additional Information (optional)