[Mac build] Add macros build #845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steelskin
force-pushed
the
fabrice/mac-build-stdlib
branch
from
5a2d842 to
6ea346c
Compare
Steelskin
force-pushed
the
fabrice/mac-build-macros
branch
2 times, most recently
from
747d816 to
992ea9b
Compare
Steelskin
force-pushed
the
fabrice/mac-build-stdlib
branch
from
6ea346c to
fb11672
Compare
Steelskin
force-pushed
the
fabrice/mac-build-stdlib
branch
4 times, most recently
from
425fe14 to
4643a5a
Compare
Steelskin
force-pushed
the
fabrice/mac-build-stdlib
branch
from
4643a5a to
fe272e4
Compare
Steelskin
force-pushed
the
fabrice/mac-build-stdlib
branch
2 times, most recently
from
718402d to
fb2523c
Compare
Steelskin
force-pushed
the
fabrice/mac-build-macros
branch
from
992ea9b to
fc58a43
Compare
compnerd
reviewed
Jan 16, 2025
Owner
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
I think that you can likely extract the naming changes as that is a purely mechanical change.
Steelskin
force-pushed
the
fabrice/mac-build-stdlib
branch
2 times, most recently
from
22f85d3 to
71128d5
Compare
Steelskin
force-pushed
the
fabrice/mac-build-stdlib
branch
from
71128d5 to
116e75d
Compare
Steelskin
force-pushed
the
fabrice/mac-build-stdlib
branch
4 times, most recently
from
4b3edb0 to
eb90037
Compare
Steelskin
force-pushed
the
fabrice/mac-build-macros
branch
2 times, most recently
from
0852548 to
6e26d5a
Compare
compnerd
approved these changes
Feb 28, 2025
Steelskin
force-pushed
the
fabrice/mac-build-macros
branch
2 times, most recently
from
519271b to
ff39455
Compare
Steelskin
force-pushed
the
fabrice/mac-build-macros
branch
2 times, most recently
from
3e9ba22 to
d6cd038
Compare
Collaborator
Author
|
Asking for a re-review now that the build is more or less fixed. I'll run another build to confirm this does not break anything. |
Steelskin
force-pushed
the
fabrice/mac-build-macros
branch
from
d6cd038 to
3d2c48c
Compare
Steelskin
force-pushed
the
fabrice/mac-build-macros
branch
2 times, most recently
from
59fea04 to
3087433
Compare
Steelskin
force-pushed
the
fabrice/mac-build-macros
branch
from
3087433 to
8aad843
Compare
Collaborator
Author
|
Abandoning this since we have diverged too much from back then and the mac build has not been maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.