Fix one compil error and one potential bug #5182
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondanadon
commented
Aug 30, 2025
raymondanadon
commented
- Fix compil error when option "WITH_CURL" is OFF
- Fix potential bug snprintf potential truncated str
Update rdkafka_conf.c Don't include header curl file
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
Can this be merged? |
|
I would love to get this merged. |
tillrohrmann
added a commit
to restatedev/rust-rdkafka
that referenced
this pull request
Nov 18, 2025
This commit picks a librdkafka version which has confluentinc/librdkafka#5182 cherry-picked on top of v2.12.1. This fixes building librdkafka w/o curl enabled where it otherwise would look for curl/curl.h because of a wrong compiler directive.
emasab
reviewed
Nov 24, 2025
Comment on lines
+4203
to
+4204
| char member_id[11]; | ||
| snprintf(member_id, 11, "consumer%d", (int)(i + 1)); |
Contributor
There was a problem hiding this comment.
Thanks for the PR! Please remove this change there's the assert rd_assert(member_cnt <= 9); at line 4192.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.