use duration instead of int

Author: R4R3D1FF

connect.go

@@ -30,6 +30,7 @@ import (
 	"io"
 	"net/http"
 	"net/url"
+	"time"
 )
 
 // Version is the semantic version of the connect module.
@@ -319,8 +320,8 @@ type Spec struct {
 	Procedure        string // for example, "/acme.foo.v1.FooService/Bar"
 	IsClient         bool   // otherwise we're in a handler
 	IdempotencyLevel IdempotencyLevel
-	ReadTimeout      int
-	WriteTimeout     int
+	ReadTimeout      time.Duration
+	WriteTimeout     time.Duration
 }
 
 // Peer describes the other party to an RPC.

handler.go

@@ -258,8 +258,8 @@ func NewBidiStreamHandler[Req, Res any](
 func (h *Handler) ServeHTTP(responseWriter http.ResponseWriter, request *http.Request) {
 	if h.spec.ReadTimeout != 0 {
 		rc := http.NewResponseController(responseWriter)
-		rc.SetReadDeadline(time.Now().Add(time.Duration(h.spec.ReadTimeout) * time.Nanosecond))
-		rc.SetWriteDeadline(time.Now().Add(time.Duration(h.spec.ReadTimeout) * time.Nanosecond))
+		rc.SetReadDeadline(time.Now().Add(h.spec.ReadTimeout))
+		rc.SetWriteDeadline(time.Now().Add(h.spec.ReadTimeout))
 	}
 
 	// We don't need to defer functions to close the request body or read to
@@ -357,8 +357,8 @@ type handlerConfig struct {
 	ReadMaxBytes                 int
 	SendMaxBytes                 int
 	StreamType                   StreamType
-	ReadTimeout                  int
-	WriteTimeout                 int
+	ReadTimeout                  time.Duration
+	WriteTimeout                 time.Duration
 }
 
 func newHandlerConfig(procedure string, streamType StreamType, options []HandlerOption) *handlerConfig {

option.go

@@ -19,6 +19,7 @@ import (
 	"context"
 	"io"
 	"net/http"
+	"time"
 )
 
 // A ClientOption configures a [Client].
@@ -351,11 +352,11 @@ func WithInterceptors(interceptors ...Interceptor) Option {
 	return &interceptorsOption{interceptors}
 }
 
-func WithReadTimeout(value int) HandlerOption {
+func WithReadTimeout(value time.Duration) HandlerOption {
 	return &readTimeoutOption{value: value}
 }
 
-func WithWriteTimeout(value int) HandlerOption {
+func WithWriteTimeout(value time.Duration) HandlerOption {
 	return &writeTimeoutOption{value: value}
 }
 
@@ -654,13 +655,13 @@ func (o *conditionalHandlerOptions) applyToHandler(config *handlerConfig) {
 	}
 }
 
-type readTimeoutOption struct{ value int }
+type readTimeoutOption struct{ value time.Duration }
 
 func (o *readTimeoutOption) applyToHandler(config *handlerConfig) {
 	config.ReadTimeout = o.value
 }
 
-type writeTimeoutOption struct{ value int }
+type writeTimeoutOption struct{ value time.Duration }
 
 func (o *writeTimeoutOption) applyToHandler(config *handlerConfig) {
 	config.WriteTimeout = o.value