fix: resolved async issues for llamastack containers (#3468)

* fix: resolved async issues for llamastack containers

Created a new interface that holds more information on the playground container.
With this new interface I updated the llamastack backend to handle stopping starting
and recreating containers based on what state they are in.

Signed-off-by: Brian <[email protected]>

* chore: fixed tests updated instructions rendering and aligned with svelte 5

Signed-off-by: Brian <[email protected]>

* chore: renamed function createboth and removed extra log

Signed-off-by: Brian <[email protected]>

---------

Signed-off-by: Brian <[email protected]>

Author: bmahabirbu

packages/backend/src/llama-stack-api-impl.ts

@@ -20,20 +20,20 @@ import { navigation } from '@podman-desktop/api';
 import type { LlamaStackAPI } from '@shared/LlamaStackAPI';
 import type { LlamaStackContainerConfiguration } from '@shared/models/llama-stack/LlamaStackContainerConfiguration';
 import type { LlamaStackManager } from './managers/llama-stack/llamaStackManager';
-import type { LlamaStackContainerInfo } from '@shared/models/llama-stack/LlamaStackContainerInfo';
+import type { LlamaStackContainers } from '@shared/models/llama-stack/LlamaStackContainerInfo';
 
 export class LlamaStackApiImpl implements LlamaStackAPI {
   constructor(private llamaStackManager: LlamaStackManager) {}
 
-  requestCreateLlamaStackContainer(config: LlamaStackContainerConfiguration): Promise<void> {
-    return this.llamaStackManager.requestCreateLlamaStackContainer(config);
+  requestcreateLlamaStackContainerss(config: LlamaStackContainerConfiguration): Promise<void> {
+    return this.llamaStackManager.requestcreateLlamaStackContainerss(config);
   }
 
   routeToLlamaStackContainerTerminal(containerId: string): Promise<void> {
     return navigation.navigateToContainerTerminal(containerId);
   }
 
-  getLlamaStackContainerInfo(): Promise<LlamaStackContainerInfo | undefined> {
-    return this.llamaStackManager.getLlamaStackContainer();
+  getLlamaStackContainersInfo(): Promise<LlamaStackContainers | undefined> {
+    return this.llamaStackManager.getLlamaStackContainers();
   }
 }

packages/backend/src/managers/application/applicationManager.spec.ts

@@ -78,7 +78,7 @@ const recipeManager = {
 } as unknown as RecipeManager;
 
 const llamaStackManager = {
-  getLlamaStackContainer: vi.fn(),
+  getLlamaStackContainers: vi.fn(),
 } as unknown as LlamaStackManager;
 
 vi.mock('@podman-desktop/api', () => ({
@@ -145,10 +145,9 @@ beforeEach(() => {
     id: 'fake-task',
   }));
   vi.mocked(modelsManagerMock.uploadModelToPodmanMachine).mockResolvedValue('downloaded-model-path');
-  vi.mocked(llamaStackManager.getLlamaStackContainer).mockResolvedValue({
-    containerId: 'container1',
-    port: 10001,
-    playgroundPort: 10002,
+  vi.mocked(llamaStackManager.getLlamaStackContainers).mockResolvedValue({
+    server: { containerId: 'container1', port: 10001, state: 'running' },
+    playground: { containerId: 'playground1', port: 10002, state: 'running' },
   });
 });
 

packages/backend/src/managers/application/applicationManager.ts

@@ -331,13 +331,13 @@ export class ApplicationManager extends Publisher<ApplicationState[]> implements
             }
           }
         } else if (options.dependencies?.llamaStack) {
-          let stack = await this.llamaStackManager.getLlamaStackContainer();
+          let stack = await this.llamaStackManager.getLlamaStackContainers();
           if (!stack) {
-            await this.llamaStackManager.createLlamaStackContainer(options.connection, labels ?? {});
-            stack = await this.llamaStackManager.getLlamaStackContainer();
+            await this.llamaStackManager.createLlamaStackContainers(options.connection, labels ?? {});
+            stack = await this.llamaStackManager.getLlamaStackContainers();
           }
           if (stack) {
-            envs = [`MODEL_ENDPOINT=http://host.containers.internal:${stack.port}`];
+            envs = [`MODEL_ENDPOINT=http://host.containers.internal:${stack.server?.port}`];
           }
         }
         if (image.ports.length > 0) {