chore: applied suggestions

Signed-off-by: Evzen Gasta <[email protected]>

Author: gastoner

packages/backend/package.json

@@ -53,11 +53,10 @@
         },
         "ai-lab.inferenceRuntime": {
           "type": "string",
-          "default": "llama-cpp",
           "enum": [
             "llama-cpp",
-            "whisper-cpp",
-            "none"
+            "openvino",
+            "vllm"
           ],
           "description": "Choose the default inferencing runtime for AI Lab"
         },

packages/backend/src/registries/ConfigurationRegistry.ts

@@ -34,7 +34,7 @@ const CONFIGURATION_SECTIONS: string[] = [
 ];
 
 const API_PORT_DEFAULT = 10434;
-const INFERENCE_RUNTIME_DEFAULT = 'llama-cpp';
+
 export class ConfigurationRegistry extends Publisher<ExtensionConfiguration> implements Disposable {
   #configuration: Configuration;
   #configurationPodmanDesktop: Configuration;
@@ -55,7 +55,7 @@ export class ConfigurationRegistry extends Publisher<ExtensionConfiguration> imp
       modelsPath: this.getModelsPath(),
       experimentalGPU: this.#configuration.get<boolean>('experimentalGPU') ?? false,
       apiPort: this.#configuration.get<number>('apiPort') ?? API_PORT_DEFAULT,
-      inferenceRuntime: this.#configuration.get<string>('inferenceRuntime') ?? INFERENCE_RUNTIME_DEFAULT,
+      inferenceRuntime: this.#configuration.get<string>('inferenceRuntime') ?? 'none',
       experimentalTuning: this.#configuration.get<boolean>('experimentalTuning') ?? false,
       modelUploadDisabled: this.#configuration.get<boolean>('modelUploadDisabled') ?? false,
       showGPUPromotion: this.#configuration.get<boolean>('showGPUPromotion') ?? true,

packages/frontend/src/lib/select/ModelSelect.svelte

@@ -47,7 +47,7 @@ function handleOnChange(nValue: (ModelInfo & { label: string; value: string }) |
   value = nValue;
 }
 
-let defaultRuntime: string = 'llama-cpp';
+let defaultRuntime: string | undefined = $state();
 
 onMount(() => {
   return configuration.subscribe(values => {
@@ -56,6 +56,13 @@ onMount(() => {
     }
   });
 });
+
+function filterModel(model: ModelInfo): boolean {
+  // If the defaultRuntime is undefined we should not filter any model
+  if (!defaultRuntime) return true;
+
+  return model.backend === defaultRuntime;
+}
 </script>
 
 <Select
@@ -66,7 +73,7 @@ onMount(() => {
   onchange={handleOnChange}
   placeholder="Select model to use"
   items={models
-    .filter(model => model.backend === defaultRuntime)
+    .filter(filterModel)
     .toSorted((a, b) => getModelSortingScore(a) - getModelSortingScore(b))
     .map(model => ({ ...model, value: model.id, label: model.name }))}>
   <div slot="item" let:item>

packages/frontend/src/pages/Recipes.svelte

@@ -103,12 +103,12 @@ function openContribution(): void {
   studioClient.openURL('https://github.com/containers/ai-lab-recipes/blob/main/CONTRIBUTING.md').catch(console.error);
 }
 
-let defaultRuntime: string = $state('llama-cpp');
+let defaultRuntime: string | undefined = $state();
 
 onMount(() => {
   const inferenceRuntime = $configuration?.inferenceRuntime;
   if (inferenceRuntime) defaultRuntime = inferenceRuntime;
-  onFilterChange('tools', defaultRuntime);
+  onFilterChange('tools', defaultRuntime ?? 'all');
 });
 </script>