fix PHP 8.5 deprecation warnings

[tenzap]

RuntimeException: Non-canonical cast (double) is deprecated, use the (float) cast instead on line 7281 in file /path/to/econea/nusoap/src/nusoap.php
RuntimeException: Non-canonical cast (boolean) is deprecated, use the (bool) cast instead on line 7287 in file /path/to/econea/nusoap/src/nusoap.php
RuntimeException: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 on line 6916 in file /path/to/econea/nusoap/src/nusoap.php

[Copilot]

Pull Request Overview

This PR addresses PHP 8.0 compatibility issues and updates type casting to use modern PHP syntax. The changes focus on conditionally calling xml_parser_free() only for PHP versions below 8.0, and updating deprecated type cast syntax.

Key Changes:

• Conditionally calls xml_parser_free() for PHP versions < 8.0 to avoid deprecation warnings
• Updates type casts from (double) to (float) and (boolean) to (bool) to align with modern PHP standards

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The use of short-circuit evaluation with && for conditionally calling xml_parser_free() is unconventional and potentially confusing. This pattern uses the logical AND operator for side effects rather than its intended purpose of boolean evaluation.

Consider using a more explicit conditional approach:

if (PHP_VERSION_ID < 80000) {
    xml_parser_free($this->parser);
}

This is clearer about intent and follows standard PHP coding practices.

Suggested change

	(PHP_VERSION_ID < 80000) && xml_parser_free($this->parser);
	if (PHP_VERSION_ID < 80000) {
	xml_parser_free($this->parser);
	}

[Copilot]

The use of short-circuit evaluation with && for conditionally calling xml_parser_free() is unconventional and potentially confusing. This pattern uses the logical AND operator for side effects rather than its intended purpose of boolean evaluation.

Consider using a more explicit conditional approach:

if (PHP_VERSION_ID < 80000) {
    xml_parser_free($this->parser);
}

This is clearer about intent and follows standard PHP coding practices.

[Copilot]

The use of short-circuit evaluation with && for conditionally calling xml_parser_free() is unconventional and potentially confusing. This pattern uses the logical AND operator for side effects rather than its intended purpose of boolean evaluation.

Consider using a more explicit conditional approach:

if (PHP_VERSION_ID < 80000) {
    xml_parser_free($this->parser);
}

This is clearer about intent and follows standard PHP coding practices.

[Copilot]

The use of short-circuit evaluation with && for conditionally calling xml_parser_free() is unconventional and potentially confusing. This pattern uses the logical AND operator for side effects rather than its intended purpose of boolean evaluation.

Consider using a more explicit conditional approach:

if (PHP_VERSION_ID < 80000) {
    xml_parser_free($this->parser);
}

This is clearer about intent and follows standard PHP coding practices.

Suggested change

	(PHP_VERSION_ID < 80000) && xml_parser_free($this->parser);
	if (PHP_VERSION_ID < 80000) {
	xml_parser_free($this->parser);
	}

[nikrou]

To complete that PR, there's one more warning : the function socket_set_timeout is an alias of stream_set_timeout. The alias is deprecated in php 8.5.