Integration into copilot.lua

[AntoineGS]

Hi @tris203!
People have been requesting nes in copilot.lua for a while and getting to work from scratch is not worth it imo.
I am hoping to borrow must of the nes code from your repo, and of course crediting you and your repo for the nes functionality.
I was able to adapt most of the code within an hour or so to create a prototype, and it seems to integrate well.
Is this something you would be OK with?
In an ideal world I would be able to checkout your repo as-is and integrate it, which would allow me to contribute to this project instead of branching off in a different direction, that is something I would be willing to work with you towards.

Here is the result of the prototype, including your license and a crediting note at the top of the Readme :)

[Xuyuanp]

Personally, You're free to use the code without needing any other permission, since it's covered by the Apache 2.0 license.

[tris203]

Yeah. I mean as long as it's in terms of the licences then you can do what you want

If the changes are minor to be able to integrate faster and let us share changes/fixes/diverge less over time I'd be interested to see them

[AntoineGS]

Personally, You're free to use the code without needing any other permission, since it's covered by the Apache 2.0 license.

Yeah I know that's the legal side of it, but at the end of the day people put in a lot of work into their projects and I'd rather things be discussed before hand :)

Yeah. I mean as long as it's in terms of the licences then you can do what you want

If the changes are minor to be able to integrate faster and let us share changes/fixes/diverge less over time I'd be interested to see them

Sounds good, I will see if I can have the plugin as a dependency as that would be even better at keeping the two projects separate and stand-alone. I'll submit a PR when I have a working integration.

Thanks for the reply!

[AntoineGS]

I was able to get it working with very minor changes in the end!
I opted for adding it as a dependency and will simply be adding a config to turn it on/off, with the configurations pertaining to this plugin staying in this plugin.
This should bring over a fair amount of new users, I will assist if there is an influx of issues created.

Here is the draft PR: #53

PS: I am not done with the integration but I doubt it will require much more changes.

[tris203]

Once I can see the changes on your side, too, then we can review it all together.

I think it's a good opportunity, people initially seemed to think that we were competitors (#38 ), but I see it as we are both heading towards the same goal

[AntoineGS]

Haha yeah there is definitely some feature overlap, I had been thinking of whether to integrate directly through the LSP or not for copilot.lua but decided against it due to the large amount of custom configs added over the years.

I made a draft PR on copilot.lua if you want to take a look.
It is still missing some details like adding the keymaps so it follows the same pattern as the existing ones, but otherwise it does seem to work fine for me (minus the annoying LSP errors #23 that pop up constantly with my debug config 🤣).

[AntoineGS]

Alright I've completed the first version of the integration!
Edit: I created 3 PRs to keep some things separate, in the description of each I put in the order in which they should be merged to keep the dependency order clean.