Skip to content

Commit 18ce557

Browse files
committed
get rebase
Signed-off-by: SungJin1212 <[email protected]>
1 parent 7a29c4c commit 18ce557

File tree

2 files changed

+15
-19
lines changed

2 files changed

+15
-19
lines changed

integration/e2e/util.go

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -429,10 +429,10 @@ func GenerateHistogramSeriesV2(name string, ts time.Time, i uint32, floatHistogr
429429
tsMillis := TimeToMilliseconds(ts)
430430

431431
st := writev2.NewSymbolTable()
432-
433-
lbs := labels.Labels{labels.Label{Name: "__name__", Value: name}}
432+
lb := labels.NewScratchBuilder(0)
433+
lb.Add("__name__", name)
434434
for _, lbl := range additionalLabels {
435-
lbs = append(lbs, labels.Label{Name: lbl.Name, Value: lbl.Value})
435+
lb.Add(lbl.Name, lbl.Value)
436436
}
437437

438438
var (
@@ -450,7 +450,7 @@ func GenerateHistogramSeriesV2(name string, ts time.Time, i uint32, floatHistogr
450450

451451
// Generate the series
452452
series = append(series, writev2.TimeSeries{
453-
LabelsRefs: st.SymbolizeLabels(lbs, nil),
453+
LabelsRefs: st.SymbolizeLabels(lb.Labels(), nil),
454454
Histograms: []writev2.Histogram{ph},
455455
})
456456

@@ -464,17 +464,15 @@ func GenerateSeriesV2(name string, ts time.Time, additionalLabels ...prompb.Labe
464464
value := rand.Float64()
465465

466466
st := writev2.NewSymbolTable()
467-
lbs := labels.Labels{{Name: labels.MetricName, Value: name}}
467+
lb := labels.NewScratchBuilder(0)
468+
lb.Add("__name__", name)
468469

469470
for _, label := range additionalLabels {
470-
lbs = append(lbs, labels.Label{
471-
Name: label.Name,
472-
Value: label.Value,
473-
})
471+
lb.Add(label.Name, label.Value)
474472
}
475473
series = append(series, writev2.TimeSeries{
476474
// Generate the series
477-
LabelsRefs: st.SymbolizeLabels(lbs, nil),
475+
LabelsRefs: st.SymbolizeLabels(lb.Labels(), nil),
478476
Samples: []writev2.Sample{
479477
{Value: value, Timestamp: tsMillis},
480478
},
@@ -512,13 +510,11 @@ func GenerateV2SeriesWithSamples(
512510
durMillis := scrapeInterval.Milliseconds()
513511

514512
st := writev2.NewSymbolTable()
515-
lbs := labels.Labels{{Name: labels.MetricName, Value: name}}
513+
lb := labels.NewScratchBuilder(0)
514+
lb.Add("__name__", name)
516515

517516
for _, label := range additionalLabels {
518-
lbs = append(lbs, labels.Label{
519-
Name: label.Name,
520-
Value: label.Value,
521-
})
517+
lb.Add(label.Name, label.Value)
522518
}
523519

524520
startTMillis := tsMillis
@@ -533,7 +529,7 @@ func GenerateV2SeriesWithSamples(
533529
}
534530

535531
series = writev2.TimeSeries{
536-
LabelsRefs: st.SymbolizeLabels(lbs, nil),
532+
LabelsRefs: st.SymbolizeLabels(lb.Labels(), nil),
537533
Samples: samples,
538534
Metadata: writev2.Metadata{
539535
Type: writev2.Metadata_METRIC_TYPE_GAUGE,

pkg/util/push/push.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
"github.com/prometheus/prometheus/config"
1212
"github.com/prometheus/prometheus/model/labels"
1313
writev2 "github.com/prometheus/prometheus/prompb/io/prometheus/write/v2"
14-
"github.com/prometheus/prometheus/storage/remote"
14+
"github.com/prometheus/prometheus/util/compression"
1515
"github.com/weaveworks/common/httpgrpc"
1616
"github.com/weaveworks/common/middleware"
1717

@@ -140,8 +140,8 @@ func Handler(remoteWrite2Enabled bool, maxRecvMsgSize int, sourceIPs *middleware
140140

141141
enc := r.Header.Get("Content-Encoding")
142142
if enc == "" {
143-
} else if enc != string(remote.SnappyBlockCompression) {
144-
err := fmt.Errorf("%v encoding (compression) is not accepted by this server; only %v is acceptable", enc, remote.SnappyBlockCompression)
143+
} else if enc != compression.Snappy {
144+
err := fmt.Errorf("%v encoding (compression) is not accepted by this server; only %v is acceptable", enc, compression.Snappy)
145145
level.Error(logger).Log("Error decoding remote write request", "err", err)
146146
http.Error(w, err.Error(), http.StatusUnsupportedMediaType)
147147
return

0 commit comments

Comments
 (0)