Skip to content

Commit fe8dee8

Browse files
committed
Remove PreciseBank by default
1 parent 296b5ea commit fe8dee8

File tree

2 files changed

+15
-40
lines changed

2 files changed

+15
-40
lines changed

evmd/app.go

Lines changed: 9 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"encoding/json"
55
"errors"
66
"fmt"
7-
87
"io"
98

109
"os"
@@ -40,9 +39,6 @@ import (
4039
"github.com/cosmos/evm/x/ibc/transfer"
4140
transferkeeper "github.com/cosmos/evm/x/ibc/transfer/keeper"
4241
transferv2 "github.com/cosmos/evm/x/ibc/transfer/v2"
43-
"github.com/cosmos/evm/x/precisebank"
44-
precisebankkeeper "github.com/cosmos/evm/x/precisebank/keeper"
45-
precisebanktypes "github.com/cosmos/evm/x/precisebank/types"
4642
"github.com/cosmos/evm/x/vm"
4743
evmkeeper "github.com/cosmos/evm/x/vm/keeper"
4844
evmtypes "github.com/cosmos/evm/x/vm/types"
@@ -187,11 +183,10 @@ type EVMD struct {
187183
CallbackKeeper ibccallbackskeeper.ContractKeeper
188184

189185
// Cosmos EVM keepers
190-
FeeMarketKeeper feemarketkeeper.Keeper
191-
EVMKeeper *evmkeeper.Keeper
192-
Erc20Keeper erc20keeper.Keeper
193-
PreciseBankKeeper precisebankkeeper.Keeper
194-
EVMMempool *evmmempool.ExperimentalEVMMempool
186+
FeeMarketKeeper feemarketkeeper.Keeper
187+
EVMKeeper *evmkeeper.Keeper
188+
Erc20Keeper erc20keeper.Keeper
189+
EVMMempool *evmmempool.ExperimentalEVMMempool
195190

196191
// the module manager
197192
ModuleManager *module.Manager
@@ -242,7 +237,7 @@ func NewExampleApp(
242237
// ibc keys
243238
ibcexported.StoreKey, ibctransfertypes.StoreKey,
244239
// Cosmos EVM store keys
245-
evmtypes.StoreKey, feemarkettypes.StoreKey, erc20types.StoreKey, precisebanktypes.StoreKey,
240+
evmtypes.StoreKey, feemarkettypes.StoreKey, erc20types.StoreKey,
246241
)
247242

248243
tkeys := storetypes.NewTransientStoreKeys(evmtypes.TransientKey, feemarkettypes.TransientKey)
@@ -405,7 +400,7 @@ func NewExampleApp(
405400

406401
app.GovKeeper = *govKeeper.SetHooks(
407402
govtypes.NewMultiGovHooks(
408-
// register the governance hooks
403+
// register the governance hooks
409404
),
410405
)
411406

@@ -428,16 +423,6 @@ func NewExampleApp(
428423
tkeys[feemarkettypes.TransientKey],
429424
)
430425

431-
// Set up PreciseBank keeper
432-
//
433-
// NOTE: PreciseBank is not needed if SDK use 18 decimals for gas coin. Use BankKeeper instead.
434-
app.PreciseBankKeeper = precisebankkeeper.NewKeeper(
435-
appCodec,
436-
keys[precisebanktypes.StoreKey],
437-
app.BankKeeper,
438-
app.AccountKeeper,
439-
)
440-
441426
// Set up EVM keeper
442427
tracer := cast.ToString(appOpts.Get(srvflags.EVMTracer))
443428

@@ -447,7 +432,7 @@ func NewExampleApp(
447432
appCodec, keys[evmtypes.StoreKey], tkeys[evmtypes.TransientKey], keys,
448433
authtypes.NewModuleAddress(govtypes.ModuleName),
449434
app.AccountKeeper,
450-
app.PreciseBankKeeper,
435+
app.BankKeeper,
451436
app.StakingKeeper,
452437
app.FeeMarketKeeper,
453438
&app.ConsensusParamsKeeper,
@@ -458,7 +443,7 @@ func NewExampleApp(
458443
precompiletypes.DefaultStaticPrecompiles(
459444
*app.StakingKeeper,
460445
app.DistrKeeper,
461-
app.PreciseBankKeeper,
446+
app.BankKeeper,
462447
&app.Erc20Keeper,
463448
&app.TransferKeeper,
464449
app.IBCKeeper.ChannelKeeper,
@@ -473,7 +458,7 @@ func NewExampleApp(
473458
appCodec,
474459
authtypes.NewModuleAddress(govtypes.ModuleName),
475460
app.AccountKeeper,
476-
app.PreciseBankKeeper,
461+
app.BankKeeper,
477462
app.EVMKeeper,
478463
app.StakingKeeper,
479464
&app.TransferKeeper,
@@ -572,7 +557,6 @@ func NewExampleApp(
572557
vm.NewAppModule(app.EVMKeeper, app.AccountKeeper, app.BankKeeper, app.AccountKeeper.AddressCodec()),
573558
feemarket.NewAppModule(app.FeeMarketKeeper),
574559
erc20.NewAppModule(app.Erc20Keeper, app.AccountKeeper),
575-
precisebank.NewAppModule(app.PreciseBankKeeper, app.BankKeeper, app.AccountKeeper),
576560
)
577561

578562
// BasicModuleManager defines the module BasicManager which is in charge of setting up basic,
@@ -620,7 +604,6 @@ func NewExampleApp(
620604
authtypes.ModuleName, banktypes.ModuleName, govtypes.ModuleName, genutiltypes.ModuleName,
621605
authz.ModuleName, feegrant.ModuleName,
622606
consensusparamtypes.ModuleName,
623-
precisebanktypes.ModuleName,
624607
vestingtypes.ModuleName,
625608
)
626609

@@ -639,7 +622,6 @@ func NewExampleApp(
639622
slashingtypes.ModuleName, minttypes.ModuleName,
640623
genutiltypes.ModuleName, evidencetypes.ModuleName, authz.ModuleName,
641624
feegrant.ModuleName, upgradetypes.ModuleName, consensusparamtypes.ModuleName,
642-
precisebanktypes.ModuleName,
643625
vestingtypes.ModuleName,
644626
)
645627

@@ -659,7 +641,6 @@ func NewExampleApp(
659641
evmtypes.ModuleName,
660642
feemarkettypes.ModuleName,
661643
erc20types.ModuleName,
662-
precisebanktypes.ModuleName,
663644

664645
ibctransfertypes.ModuleName,
665646
genutiltypes.ModuleName, evidencetypes.ModuleName, authz.ModuleName,
@@ -1064,10 +1045,6 @@ func (app *EVMD) GetMintKeeper() mintkeeper.Keeper {
10641045
return app.MintKeeper
10651046
}
10661047

1067-
func (app *EVMD) GetPreciseBankKeeper() *precisebankkeeper.Keeper {
1068-
return &app.PreciseBankKeeper
1069-
}
1070-
10711048
func (app *EVMD) GetCallbackKeeper() ibccallbackskeeper.ContractKeeper {
10721049
return app.CallbackKeeper
10731050
}

evmd/tests/integration/x_precisebank_test.go

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,16 @@ package integration
22

33
import (
44
"testing"
5-
6-
"github.com/stretchr/testify/suite"
7-
8-
"github.com/cosmos/evm/tests/integration/x/precisebank"
95
)
106

117
func TestPreciseBankGenesis(t *testing.T) {
12-
s := precisebank.NewGenesisTestSuite(CreateEvmd)
13-
suite.Run(t, s)
8+
// Uncomment these lines if using PreciseBank
9+
//s := precisebank.NewGenesisTestSuite(CreateEvmd)
10+
//suite.Run(t, s)
1411
}
1512

1613
func TestPreciseBankKeeper(t *testing.T) {
17-
s := precisebank.NewKeeperIntegrationTestSuite(CreateEvmd)
18-
suite.Run(t, s)
14+
// Uncomment these lines if using PreciseBank
15+
//s := precisebank.NewKeeperIntegrationTestSuite(CreateEvmd)
16+
//suite.Run(t, s)
1917
}

0 commit comments

Comments
 (0)