Skip to content

Commit 5f70864

Browse files
committed
review changes
1 parent 6e483a5 commit 5f70864

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

.github/workflows/node-js-packaging.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
- host: windows-latest
6969
target: aarch64-pc-windows-msvc
7070
build: yarn build --target aarch64-pc-windows-msvc
71-
name: build ${{ matrix.settings.target }}
71+
name: Build ${{ matrix.settings.target }}
7272
runs-on: ${{ matrix.settings.host }}
7373
steps:
7474
- uses: actions/checkout@v4
@@ -93,17 +93,17 @@ jobs:
9393
.cargo-cache
9494
target/
9595
key: ${{ matrix.settings.target }}-cargo-${{ matrix.settings.host }}
96-
- uses: goto-bus-stop/setup-zig@v2
97-
if: ${{ contains(matrix.settings.target, 'musl') }}
96+
- uses: mlugg/setup-zig@v2
97+
if: ${{ contains(matrix.settings.build, ' -x ') }}
9898
with:
9999
version: 0.14.1
100100
- name: Install cargo-zigbuild
101101
uses: taiki-e/install-action@v2
102-
if: ${{ contains(matrix.settings.target, 'musl') }}
102+
if: contains(matrix.settings.build, ' -x ') || contains(matrix.settings.build, '--use-cross ')
103103
env:
104104
GITHUB_TOKEN: ${{ github.token }}
105105
with:
106-
tool: cargo-zigbuild
106+
tool: ${{contains(matrix.settings.build, ' -x ') && 'cargo-zigbuild' || 'cargo-cross'}}
107107
- name: Setup toolchain
108108
run: ${{ matrix.settings.setup }}
109109
if: ${{ matrix.settings.setup }}
@@ -123,7 +123,7 @@ jobs:
123123
if-no-files-found: error
124124
build-freebsd:
125125
runs-on: ubuntu-latest
126-
name: Build FreeBSD
126+
name: Build fFreeBSD
127127
steps:
128128
- uses: actions/checkout@v4
129129
- name: Build
@@ -168,7 +168,7 @@ jobs:
168168
path: bindings/node/${{ env.APP_NAME }}.*.node
169169
if-no-files-found: error
170170
test-macOS-windows-binding:
171-
name: Test bindings on ${{ matrix.settings.target }} - node@${{ matrix.node }}
171+
name: Test ${{ matrix.settings.target }} - node@${{ matrix.node }}
172172
needs:
173173
- build
174174
strategy:

cspell.config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ words:
5151
- maturin
5252
- mdbook
5353
- mkdocs
54+
- mlugg
5455
- msvc
5556
- multiarch
5657
- musleabihf

0 commit comments

Comments
 (0)