fix clippy lints

and make CI fail on lint warnings

Author: 2bndy5

.github/workflows/pre-commit-hooks.yml

@@ -26,7 +26,7 @@ jobs:
           path: ~/.cargo
           key: ${{ runner.os }}-cargo-${{ hashFiles('Cargo.lock') }}
       - name: cargo clippy
-        run: cargo clippy
+        run: cargo clippy -- -D warnings
       - name: cargo fmt
         run: cargo fmt --check
 

cpp-linter/src/clang_tools/mod.rs

@@ -65,9 +65,9 @@ pub fn get_clang_tool_exe(name: &str, version: &str) -> Result<PathBuf> {
             // On Unix systems, this block is not likely reached. Typically, installing clang
             // will produce a symlink to the executable with the major version appended to the
             // name.
-            return Ok(cmd);
+            Ok(cmd)
         } else {
-            return Err(anyhow!("Could not find clang tool by name and version"));
+            Err(anyhow!("Could not find clang tool by name and version"))
         }
     } else {
         // `version` specified is not a semantic version; treat as path/to/bin

cpp-linter/src/git.rs

@@ -49,7 +49,7 @@ fn get_sha(repo: &Repository, depth: Option<u32>) -> Result<git2::Object<'_>, Er
 /// If there are files staged for a commit, then the resulting [`Diff`] will describe
 /// the staged changes. However, if there are no staged changes, then the last commit's
 /// [`Diff`] is returned.
-pub fn get_diff(repo: &Repository) -> Result<git2::Diff> {
+pub fn get_diff(repo: &'_ Repository) -> Result<git2::Diff<'_>> {
     let head = get_sha(repo, None).unwrap().peel_to_tree().unwrap();
     let mut has_staged_files = false;
     for entry in repo.statuses(None).unwrap().iter() {