stuff

Author: igagis

src/ruis/render/opengl/frame_buffer.cpp

@@ -43,55 +43,59 @@ frame_buffer::frame_buffer(
 		std::move(stencil)
 	)
 {
-	glGenFramebuffers(1, &this->fbo);
-	assert_opengl_no_error();
+	// In OpenGL framebuffer objects are not shared between contexts,
+	// so make sure the owning context is bound when deleting the framebuffer object.
+	this->rendering_context.get().apply([this]() {
+		glGenFramebuffers(1, &this->fbo);
+		assert_opengl_no_error();
 
-	// No need to initialize the variable because it is initialized via
-	// output argument of glGetIntegerv().
-	// NOLINTNEXTLINE(cppcoreguidelines-init-variables)
-	GLint old_fb;
-	glGetIntegerv(GL_FRAMEBUFFER_BINDING, &old_fb);
+		// No need to initialize the variable because it is initialized via
+		// output argument of glGetIntegerv().
+		// NOLINTNEXTLINE(cppcoreguidelines-init-variables)
+		GLint old_fb;
+		glGetIntegerv(GL_FRAMEBUFFER_BINDING, &old_fb);
 
-	glBindFramebuffer(GL_FRAMEBUFFER, this->fbo);
-	assert_opengl_no_error();
+		glBindFramebuffer(GL_FRAMEBUFFER, this->fbo);
+		assert_opengl_no_error();
 
-	if (this->color) {
-		ASSERT(dynamic_cast<texture_2d*>(this->color.get()))
-		// NOLINTNEXTLINE(cppcoreguidelines-pro-type-static-cast-downcast)
-		auto& tex = static_cast<texture_2d&>(*this->color);
+		if (this->color) {
+			ASSERT(dynamic_cast<texture_2d*>(this->color.get()))
+			// NOLINTNEXTLINE(cppcoreguidelines-pro-type-static-cast-downcast)
+			auto& tex = static_cast<texture_2d&>(*this->color);
 
-		glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, tex.tex, 0);
-		assert_opengl_no_error();
-	} else {
-		// TODO: glDrawBuffer(GL_NONE) ? See https://gamedev.stackexchange.com/a/152047
-	}
+			glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, tex.tex, 0);
+			assert_opengl_no_error();
+		} else {
+			// TODO: glDrawBuffer(GL_NONE) ? See https://gamedev.stackexchange.com/a/152047
+		}
 
-	if (this->depth) {
-		ASSERT(dynamic_cast<texture_depth*>(this->depth.get()))
-		// NOLINTNEXTLINE(cppcoreguidelines-pro-type-static-cast-downcast)
-		auto& tex = static_cast<texture_depth&>(*this->depth);
+		if (this->depth) {
+			ASSERT(dynamic_cast<texture_depth*>(this->depth.get()))
+			// NOLINTNEXTLINE(cppcoreguidelines-pro-type-static-cast-downcast)
+			auto& tex = static_cast<texture_depth&>(*this->depth);
 
-		glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, tex.tex, 0);
-		assert_opengl_no_error();
-	}
+			glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, tex.tex, 0);
+			assert_opengl_no_error();
+		}
 
-	if (this->stencil) {
-		throw std::logic_error("frame_buffer(): OpenGL stencil texture support is not implemented");
-	}
+		if (this->stencil) {
+			throw std::logic_error("frame_buffer(): OpenGL stencil texture support is not implemented");
+		}
 
-	// check for completeness
-	{
-		GLenum status = glCheckFramebufferStatus(GL_FRAMEBUFFER);
-		assert_opengl_no_error();
-		if (status != GL_FRAMEBUFFER_COMPLETE) {
-			throw std::runtime_error(
-				utki::cat("frame_buffer(): OpenGL framebuffer is incomplete: status = ", unsigned(status))
-			);
+		// check for completeness
+		{
+			GLenum status = glCheckFramebufferStatus(GL_FRAMEBUFFER);
+			assert_opengl_no_error();
+			if (status != GL_FRAMEBUFFER_COMPLETE) {
+				throw std::runtime_error(
+					utki::cat("frame_buffer(): OpenGL framebuffer is incomplete: status = ", unsigned(status))
+				);
+			}
 		}
-	}
 
-	glBindFramebuffer(GL_FRAMEBUFFER, old_fb);
-	assert_opengl_no_error();
+		glBindFramebuffer(GL_FRAMEBUFFER, old_fb);
+		assert_opengl_no_error();
+	});
 }
 
 frame_buffer::~frame_buffer()