Skip to content

Commit 7a6335e

Browse files
committed
fix lint
1 parent ea5d308 commit 7a6335e

File tree

6 files changed

+19
-9
lines changed

6 files changed

+19
-9
lines changed

src/ruis/widget/base/list_providable.hpp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class list_providable;
3333
* @brief Item widgets provider class.
3434
* User should subclass this class to provide item widgets to a list_providable.
3535
*/
36-
class list_provider : virtual public utki::shared
36+
class list_provider
3737
{
3838
friend class list_providable;
3939

@@ -43,6 +43,14 @@ class list_provider : virtual public utki::shared
4343
list_provider(utki::shared_ref<ruis::context> context);
4444

4545
public:
46+
list_provider(const list_provider&) = delete;
47+
list_provider& operator=(const list_provider&) = delete;
48+
49+
list_provider(list_provider&&) = delete;
50+
list_provider& operator=(list_provider&&) = delete;
51+
52+
virtual ~list_provider() = default;
53+
4654
const utki::shared_ref<ruis::context> context;
4755

4856
/**

src/ruis/widget/group/table_list.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
2727

2828
namespace ruis {
2929

30+
// NOLINTNEXTLINE(bugprone-incorrect-enable-shared-from-this, "std::enable_shared_from_this is public via widget inheritance")
3031
class table_list :
3132
virtual public widget, //
3233
private container

src/ruis/widget/group/table_tree_view.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
2727

2828
namespace ruis {
2929

30+
// NOLINTNEXTLINE(bugprone-incorrect-enable-shared-from-this, "std::enable_shared_from_this is public via widget inheritance")
3031
class table_tree_view :
3132
virtual public ruis::widget, //
3233
private ruis::container

src/ruis/widget/group/tiling_area.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ class dragger : public ruis::gap
4141
ruis::mouse_cursor_stack::iterator arrows_cursor_iter;
4242

4343
public:
44+
// TODO: use shared_ref?
4445
std::shared_ptr<ruis::widget> prev_widget;
4546
std::shared_ptr<ruis::widget> next_widget;
4647

src/ruis/widget/group/tiling_area.hpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,12 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
2727

2828
namespace ruis {
2929

30-
/*
31-
The tile_area arranges its content widgets (tiles) either vertially or horizontally.
32-
Common borders of the contained tiles are draggable with mouse pointer.
33-
*/
30+
/**
31+
* @brief Tiling area.
32+
* The tile_area arranges its content widgets (tiles) either vertially or horizontally.
33+
* Common borders of the adjacent contained tiles are draggable with mouse pointer.
34+
*/
35+
// NOLINTNEXTLINE(bugprone-incorrect-enable-shared-from-this, "std::enable_shared_from_this is public via widget inheritance")
3436
class tiling_area :
3537
virtual public widget, //
3638
public ruis::oriented,

src/ruis/widget/group/tree_view.hpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,7 @@ class tree_view :
4545
* User subclasses this class to provide tree_view an access to the tree data model
4646
* and provide a way to represent the data as widgets.
4747
*/
48-
// NOLINTNEXTLINE(bugprone-incorrect-enable-shared-from-this, "std::shared_from_this is public via utki::shared")
49-
class provider :
50-
public virtual utki::shared, //
51-
private list_provider
48+
class provider : private list_provider
5249
{
5350
friend class tree_view;
5451

0 commit comments

Comments
 (0)